Enable Multivalue again #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With LLVM 19 they explicitly require using the `experimental-mv` ABI in addition to the `multivalue` LLVM feature (the latter is enabled by default now). Enabling the ABI is non-trivial and requires a full on custom Rust target. This adds `wasm32-multivalue.json` which is identical to `wasm32-unknown-unknown` except it sets the `experimental-mv` ABI. The target JSON format is very experimental by itself, so we may need to keep this up to date from time to time.
CryZe
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With LLVM 19 they explicitly require using the
experimental-mvABI in addition to themultivalueLLVM feature (the latter is enabled by default now). Enabling the ABI is non-trivial and requires a full on custom Rust target. This addswasm32-multivalue.jsonwhich is identical towasm32-unknown-unknownexcept it sets theexperimental-mvABI. The target JSON format is very experimental by itself, so we may need to keep this up to date from time to time.