Introduce Custom Dialogs #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces custom dialogs to LiveSplit One. Previously we've used the builtin browser dialogs that are very limited in what they can do. Additionally this introduces a bunch of smaller changes: - The splits editor is now more optimized and only searches for the game name whenever it or the list of games changes. - The PWA badge now resets when the app is reloaded. - Guests on the leaderboard can now have flags. - If a user encounters a bug, there's now dedicated toast popups that don't disappear and direct the user to the issue tracker. - The Sum of Best cleaner now ensures the run can't be modified while the cleaning is in progress, which would lead to memory corruption, especially with the async nature of the new dialogs. - Cancelling out of opening files doesn't lead to an error anymore. The following changes are introduced by updating `livesplit-core`: - When resizing images / reencoding them as PNG, we now use a higher compression setting. - Invalid timer states are not unrepresentable anymore.
CryZe
added
bug
This was
linked to
issues
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces custom dialogs to LiveSplit One. Previously we've used the builtin browser dialogs that are very limited in what they can do.
Additionally this introduces a bunch of smaller changes:
The following changes are introduced by updating
livesplit-core: