Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decaffeinate, convert to (relatively) modern JS #620

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open
3 changes: 3 additions & 0 deletions .babelrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"presets": [["@babel/preset-env", { "targets": { "node": "current" } }]]
}
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
*.swp
lib
node_modules
npm-debug.log
.nyc_output
Expand Down
4 changes: 0 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@ We're always happy about useful new pull requests. Keep in mind that the better
your pull request is, the easier it can be added to `xml2js`. As such please
make sure your patch is ok:

* `xml2js` is written in CoffeeScript. Please don't send patches to
the JavaScript source, as it get's overwritten by the CoffeeScript
compiler. The reason we have the JS code in the repository is for easier
use with eg. `git submodule`
* Make sure that the unit tests still all pass. Failing unit tests mean that
someone *will* run into a bug, if we accept your pull request.
* Please, add a unit test with your pull request, to show what was broken and
Expand Down
13 changes: 0 additions & 13 deletions Cakefile

This file was deleted.

4 changes: 1 addition & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -487,9 +487,7 @@ We also have a number of unit tests, they can be run using `npm test` directly
from the project root. This runs zap to discover all the tests and execute
them.

If you like to contribute, keep in mind that `xml2js` is written in
CoffeeScript, so don't develop on the JavaScript files that are checked into
the repository for convenience reasons. Also, please write some unit test to
If you like to contribute, please write some unit test to
check your behaviour and if it is some user-facing thing, add some
documentation to this README, so people will know it exists. Thanks in advance!

Expand Down
7 changes: 5 additions & 2 deletions bower.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"name": "xml2js",
": "xml2js",
"description": "Simple XML to JavaScript object converter.",
"keywords": [
"xml",
Expand Down Expand Up @@ -61,11 +60,15 @@
"xmlbuilder": "oozcitak/xmlbuilder-js"
},
"devDependencies": {
"@babel/cli": "^7.14.5",
"@babel/core": "^7.14.6",
"@babel/preset-env": "^7.4.2",
"coffee-script": ">=1.10.0",
"coveralls": "nickmerwin/node-coveralls",
"diff": "kpdecker/jsdiff",
"docco": "jashkenas/docco",
"nyc": "bcoe/nyc",
"standardx": "^7.0.0",
"zap": "nornagon/node-zap"
},
"ignore": [
Expand Down
12 changes: 0 additions & 12 deletions lib/bom.js

This file was deleted.

127 changes: 0 additions & 127 deletions lib/builder.js

This file was deleted.

72 changes: 0 additions & 72 deletions lib/defaults.js

This file was deleted.

Loading