Add optional validator properties to CosmosTransaction #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a3dbb2d The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Justkant
approved these changes
Aug 30, 2023
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Adds optional
validatorsandsourceValidatorproperties to theCosmosTransactioninterface and adjustment to the related serializer, and schema validation based on a Ledger Live Common type found in the Ledger Live monorepo here.❓ Context
We are currently building a ledger live app for StakeKit that offers users a unified non-custodial staking experience across a wide range of networks and protocols. We were unable to use the Wallet API to sign and broadcast Cosmos Delegate transactions. After investigating the ledger-live monorepo and modifying the CosmosTransaction interface, serializer and schema validation to match the type in the monorepo, we were able to successfully sign the transaction using the Wallet API.
✅ Checklist
📸 Demo
Screen.Recording.2023-08-25.at.17.43.29.mov