Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64
This PR is a workaround that implements
cx_bn_gf2_n_mul()
in the SDK until it is hopefully added as a syscall like in all other Ledger devices.As the second Montgomery constant (
bn_h
) is an unused attribute here it begs the question how is the second Montgomery constant (bn_h
) used in the implementation ofcx_bn_gf2_n_mul()
on Nano S Plus, Nano X and Stax devices? Is it also unused on these devices?Note
The code in this PR is already included in the app-seed-tool which has passed Ledger's security review.