Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong text shortening in some corner cases ("..." being longer than 2 chars) #779

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

nroggeman-ledger
Copy link
Contributor

Description

The goal of this PR is to fix text shortening (nbgl_textWrapOnNbLines()) in some corner cases ("..." being longer than 2 chars)

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 35.76%. Comparing base (1acfccd) to head (5d42057).

Files with missing lines Patch % Lines
lib_nbgl/src/nbgl_fonts.c 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #779      +/-   ##
==========================================
+ Coverage   35.67%   35.76%   +0.08%     
==========================================
  Files          13       13              
  Lines        1595     1591       -4     
==========================================
  Hits          569      569              
+ Misses       1026     1022       -4     
Flag Coverage Δ
unittests 35.76% <0.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@ndedouhet-ledger ndedouhet-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nroggeman-ledger nroggeman-ledger merged commit cdcd9d8 into master Sep 25, 2024
178 checks passed
@nroggeman-ledger nroggeman-ledger deleted the fix-wrong-text-shortening-in-some-cases branch September 25, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants