Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BACK-6974: New schema for EIP712 #171

Merged
merged 6 commits into from
May 15, 2024
Merged

BACK-6974: New schema for EIP712 #171

merged 6 commits into from
May 15, 2024

Conversation

ClaireGuerreGiordano
Copy link
Contributor

@ClaireGuerreGiordano ClaireGuerreGiordano commented Apr 15, 2024

This PR aims to add additional schema for EIP712 as specified here
Diff with former schema are there additional properties:

                                                "assetPath": {
                                                    "type": "string"
                                                },
                                                "datetime": {
                                                    "format": "date-time",
                                                    "type": "string"
                                                },
                                                "format": {
                                                    "enum": [
                                                        "token",
                                                        "amount"
                                                    ]
                                                },
                                                "raw": {
                                                    "type": "string"
                                                }

@ClaireGuerreGiordano ClaireGuerreGiordano marked this pull request as ready for review May 6, 2024 14:58
@ClaireGuerreGiordano ClaireGuerreGiordano requested a review from a team as a code owner May 6, 2024 14:58
Copy link
Contributor

@jnicoulaud-ledger jnicoulaud-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a description to your PR referencing specs for proper historization ? Thanks!

Adding diff of the schema for clarity:

❯ difft ethereum/eip712.schema.json ethereum/eip712-v2.schema.json                                            back6974
ethereum/eip712-v2.schema.json --- JSON
34 34                                                 "properties": {
.. 35                                                     "assetPath": {
.. 36                                                         "type": "string"
.. 37                                                     },
.. 38                                                     "format": {
.. 39                                                         "enum": [
.. 40                                                             "coin",
.. 41                                                             "amount",
.. 42                                                             "address"
.. 43                                                         ]
.. 44                                                     },
35 45                                                     "label": {

ethereum/eip712-v2.schema.json Show resolved Hide resolved
ethereum/eip712-v2.schema.json Show resolved Hide resolved
ethereum/eip712-v2.schema.json Show resolved Hide resolved
ethereum/eip712-v2.schema.json Outdated Show resolved Hide resolved
ethereum/eip712-v2.schema.json Outdated Show resolved Hide resolved
ethereum/eip712-v2.schema.json Show resolved Hide resolved
@ClaireGuerreGiordano ClaireGuerreGiordano requested a review from a team as a code owner May 10, 2024 13:57
@ClaireGuerreGiordano ClaireGuerreGiordano merged commit 49190e9 into main May 15, 2024
6 checks passed
@ClaireGuerreGiordano ClaireGuerreGiordano deleted the back6974 branch May 15, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants