Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add swell #170

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Add swell #170

merged 1 commit into from
Apr 12, 2024

Conversation

chcmedeiros
Copy link
Contributor

No description provided.

@chcmedeiros chcmedeiros requested a review from a team as a code owner April 11, 2024 08:01
@jnicoulaud-ledger
Copy link
Contributor

Hello @chcmedeiros , you need to run pipenv run validate_files to format files properly and push changes

jnicoulaud-ledger
jnicoulaud-ledger approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@jnicoulaud-ledger jnicoulaud-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
https://etherscan.io/address/0x46ddc39e780088b1b146aba8cbbe15dc321a1a1d
https://etherscan.io/address/0xfae103dc9cf190ed75350761e95403b7b8afa6c0

@jnicoulaud-ledger
Copy link
Contributor

@chcmedeiros: my bad, one last thing: you also need to GPG sign your commit (eg: with git commit -S --amend)

@jnicoulaud-ledger jnicoulaud-ledger merged commit 30b06aa into LedgerHQ:main Apr 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnicoulaud-ledger jnicoulaud-ledger jnicoulaud-ledger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chcmedeiros @jnicoulaud-ledger