Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💚 (sonarqube) [NO-ISSUE]: Reenable sonarqube #498

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

💚 (sonarqube) [NO-ISSUE]: Reenable sonarqube #498

wants to merge 2 commits into from
+39 −30

Conversation

valpinkman
Copy link
Member

📝 Description

Sonarqube has been broken since me moved the repo to public. This PR aims to fix it.

❓ Context

  • JIRA or GitHub link: [NO-ISSUE]
  • Feature:

✅ Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided
  • Impact of the changes:
    • list of the changes

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

@valpinkman valpinkman requested a review from a team as a code owner November 15, 2024 09:59
@vercel Vercel
Copy link

vercel bot commented Nov 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
device-sdk-ts-sample ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 5:09pm
doc-device-management-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 5:09pm

@valpinkman valpinkman marked this pull request as draft November 15, 2024 09:59
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024 •
edited
Loading

Messages
⚠️ No changeset file found in the PR. Please add a changeset file.

Generated by 🚫 dangerJS against 17ffd07

@valpinkman valpinkman marked this pull request as ready for review November 15, 2024 15:16
@valpinkman valpinkman force-pushed the chore/no-issue-sonarqube-fix branch 2 times, most recently from a609d7e to ebd28f5 Compare November 15, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@valpinkman valpinkman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@valpinkman