✨ (dmk) [DSDK-542]: Add API calls and models for secure channel #469
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jdabbech-ledger
force-pushed
the
feat/dsdk-542-secure-channel-api-calls
branch
from
14008f2
to
1090224
Compare
| @@ -91,7 +91,10 @@ export class GetOsVersionCommand implements Command<GetOsVersionResponse> { | |||
| } | |||
| const parser = new ApduParser(apduResponse); | |||
|
|
|||
| const targetId = parser.encodeToHexaString(parser.extractFieldByLength(4)); | |||
| const targetId = parseInt( | |||
There was a problem hiding this comment.
[ASK] why parseInt then toString on a string ?
There was a problem hiding this comment.
To convert the hexastring to a decimal string, because the API only accept base 10 number for targetId.
The base 10 conversion has to be done on the whole number.
| type BaseFirmware = { | ||
| id: number; | ||
| name: string; | ||
| description: string | null | undefined; |
There was a problem hiding this comment.
[ASK] Do we really need null and undefined ?
There was a problem hiding this comment.
As it's a model that comes from API, I guess yes.
There was a problem hiding this comment.
Is there any API doc for this endpoint ?
There was a problem hiding this comment.
Not that I know of, this type is the same in LL
There was a problem hiding this comment.
Yeah I was thinking if the null is really useful here or needed for the business logic on the LL side
jdabbech-ledger
force-pushed
the
feat/dsdk-542-secure-channel-api-calls
branch
from
1090224
to
9b0f85f
Compare
📝 Description
Manager api calls for secure channel
❓ Context
✅ Checklist
Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.
🧐 Checklist for the PR Reviewers