💄 (smpl) [DSDK-518]: Update device selection according to figma #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jdabbech-ledger
changed the base branch from
develop
to
feat/dsdk-440-ble-device-connection
jdabbech-ledger
changed the title
jdabbech-ledger
force-pushed
the
feat/dsdk-518-device-selection-design
branch
from
08d982f
to
bf37266
Compare
jdabbech-ledger
force-pushed
the
feat/dsdk-440-ble-device-connection
branch
from
cee6a89
to
2305693
Compare
jdabbech-ledger
force-pushed
the
feat/dsdk-518-device-selection-design
branch
from
bf37266
to
aeb3700
Compare
jdabbech-ledger
force-pushed
the
feat/dsdk-440-ble-device-connection
branch
2 times, most recently
from
2b2f555
to
0ceb52d
Compare
jdabbech-ledger
force-pushed
the
feat/dsdk-518-device-selection-design
branch
from
aeb3700
to
ed8d956
Compare
jdabbech-ledger
force-pushed
the
feat/dsdk-440-ble-device-connection
branch
from
0ceb52d
to
6faac6a
Compare
jdabbech-ledger
force-pushed
the
feat/dsdk-518-device-selection-design
branch
from
ed8d956
to
1233680
Compare
aussedatlo
approved these changes
Oct 4, 2024
| @@ -3,7 +3,7 @@ import { Flex, Text, Drawer } from "@ledgerhq/react-ui"; | |||
|
|
|||
| export const StyledDrawer: React.FC<{ | |||
| title: string; | |||
| description: string; | |||
| description?: string; | |||
There was a problem hiding this comment.
[COULD] move optional parameter at the end
jdabbech-ledger
force-pushed
the
feat/dsdk-440-ble-device-connection
branch
3 times, most recently
from
a3e09a1
to
2fb8880
Compare
jdabbech-ledger
force-pushed
the
feat/dsdk-440-ble-device-connection
branch
8 times, most recently
from
ccbda27
to
dd61a4e
Compare
Base automatically changed from
feat/dsdk-440-ble-device-connection
to
develop
October 18, 2024 12:22
jdabbech-ledger
force-pushed
the
feat/dsdk-518-device-selection-design
branch
from
1233680
to
ef58ea5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Select Device in a drawer
Update e2e tests according to the new UI
❓ Context
✅ Checklist
Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.
device-selection.mp4
🧐 Checklist for the PR Reviewers