Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add stax support to docker-make #72

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: add stax support to docker-make #72

wants to merge 1 commit into from

Conversation

kewde
Copy link

@kewde kewde commented Jul 4, 2023

  • untags ledger-app-builder to latest rather than 73c9e07
  • docs updated to get ledger-app-builder from github packages
  • adds stax support to docker-make

t-nelson
t-nelson reviewed Jul 4, 2023
View reviewed changes
docker-make
@@ -1,5 +1,5 @@
#!/usr/bin/env bash
docker_tag=73c9e07
docker_tag=latest
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer a named tag. latest lets the docker image wreck your dev environment behind your back. the docker image should only be updated intentionally and along with any required compatibility changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-nelson t-nelson t-nelson left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kewde @t-nelson