Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix amount formatting #669

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Fix amount formatting #669

merged 2 commits into from
Nov 4, 2024

Conversation

apaillier-ledger
Copy link
Contributor

Description

  • Fix amount buffer being not big enough to accommodate a ticker if the amount is already the largest possible
  • Fix two calls to amountToString having a hardcoded (and wrong) output buffer size

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@apaillier-ledger apaillier-ledger marked this pull request as ready for review October 30, 2024 12:26
@apaillier-ledger apaillier-ledger merged commit d3e6ff7 into develop Nov 4, 2024
156 of 157 checks passed
@apaillier-ledger apaillier-ledger deleted the fix/apa/amount_formatting branch November 4, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@apaillier-ledger