Fix step idx logging and eval frequency #76
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step index is incorrectly logged as a metric, it should be passed as the
step
keyword argument tologger.log
, otherwise the logger (W&B, etc.) will just assume 1:1 indexing. This is a problem for anyone using logging frequency different than 1.Additionally, I’ve changed eval logic to only proc if the step index is divisible by 10, so that eval doesn’t run on every step.