Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta: Add -Wlogical-op to the default compile options #2351

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Meta: Add -Wlogical-op to the default compile options #2351

merged 1 commit into from
Nov 15, 2024
+1 −0

Conversation

ADKaster
Copy link
Member

No description provided.

nico
nico approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@nico nico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Do you want to give -Wdouble-promotion a try too? It'll need some cleanup, but not a ton. (I've cherry picked about half your PRs, and needed to amend < 5 for it.)

@ADKaster ADKaster merged commit 137db0e into LadybirdBrowser:master Nov 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nico nico nico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ADKaster @nico