LibWeb/HTML: Dispatch toggle and beforetoggle events from dialogs #2223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we make a test? I guess something like <html>
<body>
<dialog id="test-dialog">Test Dialog</dialog>
<script>
const dialog = document.getElementById('test-dialog');
let preventNextToggle = false;
dialog.addEventListener('beforetoggle', (event) => {
console.log(`beforetoggle event fired: open=${dialog.open}`);
if (preventNextToggle) {
event.preventDefault();
console.log('Toggle action prevented');
}
});
dialog.addEventListener('toggle', () => {
console.log(`toggle event fired: open=${dialog.open}`);
});
async function runTests() {
console.log('--- Running Tests for Patch ---');
// Test 1: Prevent toggle from closed to open
console.log('Test 1: Prevent toggle from closed to open');
preventNextToggle = true;
dialog.show();
await new Promise(r => setTimeout(r, 10)); // Wait for events
console.log(dialog.open === false ? 'success' : 'fail');
// Test 2: Prevent toggle from open to closed
console.log('Test 2: Prevent toggle from open to closed');
dialog.show(); // Ensure dialog is open
preventNextToggle = true;
dialog.close();
await new Promise(r => setTimeout(r, 10));
console.log(dialog.open === true ? 'success' : 'fail');
// Test 3: Ensure toggle event is dispatched on open
console.log('Test 3: Ensure toggle event is dispatched on open');
preventNextToggle = false;
let toggleFired = false;
dialog.addEventListener('toggle', () => toggleFired = true, { once: true });
dialog.show();
await new Promise(r => setTimeout(r, 10));
console.log(toggleFired ? 'success' : 'fail');
// Test 4: Ensure toggle event is dispatched on close
console.log('Test 4: Ensure toggle event is dispatched on close');
toggleFired = false;
dialog.addEventListener('toggle', () => toggleFired = true, { once: true });
dialog.close();
await new Promise(r => setTimeout(r, 10));
console.log(toggleFired ? 'success' : 'fail');
}
runTests();
</script>
</body>
</html>should work |
|
I avoided adding a test because we still have so many FIXMEs in this code, that I'm not sure it does anything correctly enough to test. I can try importing some WPT tests if needed though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponds to whatwg/html#10091