Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX: XDPBenchResults: split inheritance tree #385

Merged
merged 2 commits into from
Oct 30, 2024

Commits on Oct 24, 2024

  1. XDPBenchResults: split inheritance tree

    `XDPBenchMeasurements` results used to use `FlowMeasurementResults`
    as a base class overriding some of its methods because xdp-bench
    tool doesn't measure CPU usage and so `FlowMeasurementResults`
    CPU metrics were set to `None`.
    
    Recent changes from [0] now expects `FlowMeasurementResults` to
    use both perf and CPU results. Especially
    `.{start,end}_timestamp` properties expect CPU metrics to be set
    and if not, it crashes since not using CPU metrics is "masked"
    by setting `None` instead of regular result containers.
    
    [0] LNST-project#382
    enhaut committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    2c4ae7c View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. XDPBenchMeasurement: fixed json formatter

    `JsonRunSummaryFormatter` requires measurement results to be
    instance of `MeasurementResult` class.
    enhaut committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    1f80931 View commit details
    Browse the repository at this point in the history