Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added XDP tx recipe #384

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Added XDP tx recipe #384

merged 3 commits into from
Nov 12, 2024

Conversation

enhaut
Copy link
Member

@enhaut enhaut commented Oct 23, 2024

Description

  • exported parameters of XDPBench test tool to measurement
  • added XDP tx test
    The test measures how fast the CPU can read an incoming packet, swap MACs and send it back using the same NIC. It's basically hairpinning

Tests

Functional test ox xdp drop + xdp tx recipes in J:10038813

@enhaut enhaut changed the title Xdp tx Added XDP tx recipe Oct 23, 2024
Copy link
Collaborator

@olichtne olichtne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor commit refactoring comment, otherwise looks ok

@enhaut
Copy link
Member Author

enhaut commented Nov 11, 2024

Final round of tests, if they pass, we can merge.
J:10166296

The format of xdp-bench tx is a bit different. The error
column also includes dropped packets:
```
Summary X rx/s Y err,drop/s
```

The drop mode drops the packets, so drops are not considered
as errors:
```
Summary X rx/s Y err/s
```
All the params that are passed to `xdp-bench` tool needs to be
able to use them within LNST.
`XDPBench._prepare_arguments` ignores empty parameters set to
empty string. Thats because not all of the params are applicable
to all XDP bench modes but we still need a way of providing them
to XDPBench so these are passed to XDPBench but set to empty str.

More elegant way would be splitting `XDPBench` into multiple
test modules based on mode it runs...
@enhaut
Copy link
Member Author

enhaut commented Nov 11, 2024

Rebased, and final final final round of tests in J:10167258 :D

@enhaut enhaut requested a review from olichtne November 12, 2024 12:35
Copy link
Collaborator

@olichtne olichtne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok, merging.

@olichtne olichtne merged commit a5ee313 into LNST-project:master Nov 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants