Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vxlan hw tc offload #342

Merged
merged 6 commits into from
Nov 2, 2023

Conversation

jtluka
Copy link
Collaborator

@jtluka jtluka commented Oct 30, 2023

Description

This pull request adds new tests SRIOVNetns[Vxlan|Geneve]TcRecipe. To avoid code duplication I moved most of the functionality to
a new base class BaseSRIOVNetnsTcRecipe and updated the existing SRIOVNetnsTcRecipe to use the base class.

The new base class provides two common methods that the derived class overrides:

  • add_tc_filter_rules() (must be defined by every derived class)
  • add_network_layers() (optional, to define additional network stacks, for example tunnels between VFs)

Tests

J:8496033
J:8496862 (with geneve)
J:8508546

Reviews

@Axonis @olichtne

Copy link
Collaborator

@olichtne olichtne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly ok, but i'd like to now keep consistency with avoiding to use the ip_filters method for using followup configuration commands. this can lead to non-deterministic behaviour in case of issues with configuration.

other than this i'll also check the test runs but i assume if everything is working that this should be ok.

@olichtne
Copy link
Collaborator

olichtne commented Nov 1, 2023

one more question the test you link to J:8496862 (with geneve) has 3mlx5_core_25g tests, 3mlx5_cx6dx tests but only 1*ice test, is this intentional?

@jtluka
Copy link
Collaborator Author

jtluka commented Nov 1, 2023

one more question the test you link to J:8496862 (with geneve) has 3_mlx5_core_25g tests, 3_mlx5_cx6dx tests but only 1*ice test, is this intentional?

yes, ice does not have hw offload for encap/decapsulation, so I do not plan to add these in the test set.

@olichtne olichtne merged commit be9f9a0 into LNST-project:master Nov 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants