MRI-adaptivity #564
Open
MRI-adaptivity #564
+24,067
−3,783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as its own inner stepper
…o feature/mri-adaptivity
drreynolds
requested review from
balos1,
gardner48 and
cswoodward
as code owners
…iate success/recoverable/unrecoverable flags
…ontrols' for multirate temporal error
…t the start of an adaptive step attempt. The previous attempt at this logic was insufficient. I recommend that we defer further optimization until this can be used with application partners.
…MRIStepInnerStepper
…o feature/mri-adaptivity
|
I believe that I've finished addressing all PR comments. Aside from Jenkins, this is passing all CI tests, so once I VPN in to identify/resolve those (likely changes in some |
drreynolds
dismissed
gardner48’s stale review
dismissing previous review, since GitHub can no longer show me any remaining requested changes.
balos1
reviewed
Nov 7, 2024
balos1
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that this PR is now ready for full review.
Note: I removed all of the changesets that I'd pulled from @Steven-Roberts's PR #547 to simplify the review process for this PR.