CI: Update Compiler Warnings, Enable Warnings as Errors

cmake/SundialsSetupCompilers.cmake

@@ -76,8 +76,18 @@ endif()
 if(ENABLE_ALL_WARNINGS)
   message(STATUS "Enabling all compiler warnings")
 
-  set(CMAKE_C_FLAGS "-Wall -Wpedantic -Wextra -Wno-unused-parameter -Wno-deprecated-declarations -Wno-unused-function ${CMAKE_C_FLAGS}")
-  set(CMAKE_CXX_FLAGS "-Wall -Wpedantic -Wextra -Wno-unused-parameter -Wno-deprecated-declarations -Wno-unused-function ${CMAKE_CXX_FLAGS}")
+  if(SUNDIALS_PRECISION MATCHES "EXTENDED")
+    set(CMAKE_C_FLAGS "-Wdouble-promotion ${CMAKE_C_FLAGS}")
+    set(CMAKE_CXX_FLAGS "-Wdouble-promotion ${CMAKE_CXX_FLAGS}")
+  endif()
+
+  if((SUNDIALS_PRECISION MATCHES "DOUBLE") AND (SUNDIALS_INDEX_SIZE MATCHES "32"))
+    set(CMAKE_C_FLAGS "-Wconversion -Wno-sign-conversion ${CMAKE_C_FLAGS}")
+    set(CMAKE_CXX_FLAGS "-Wconversion -Wno-sign-conversion ${CMAKE_CXX_FLAGS}")
+  endif()
+
+  set(CMAKE_C_FLAGS "-Wall -Wpedantic -Wextra -Wshadow -Wmissing-declarations -Wcast-qual -Wno-unused-parameter -Wno-unused-function ${CMAKE_C_FLAGS}")
+  set(CMAKE_CXX_FLAGS "-Wall -Wpedantic -Wextra -Wshadow -Wmissing-declarations -Wcast-qual -Wno-unused-parameter -Wno-unused-function ${CMAKE_CXX_FLAGS}")
   set(CMAKE_Fortran_FLAGS "-Wall -Wpedantic -Wno-unused-dummy-argument -Wno-c-binding-type -ffpe-summary=none ${CMAKE_Fortran_FLAGS}")
 endif()
 

examples/arkode/CXX_parallel/ark_heat2D_p.cpp

@@ -1720,7 +1720,7 @@ static int OpenOutput(UserData* udata)
 static int WriteOutput(sunrealtype t, N_Vector u, UserData* udata)
 {
   int flag;
-  sunrealtype max;
+  sunrealtype max = ZERO;
   bool outproc = (udata->myid_c == 0);
 
   if (udata->output > 0)

examples/arkode/CXX_parhyp/ark_heat2D_hypre_ls.cpp

@@ -470,31 +470,9 @@ int main(int argc, char* argv[])
   flag = ARKodeSetEpsLin(arkode_mem, udata->epslin);
   if (check_flag(&flag, "ARKodeSetEpsLin", 1)) { return 1; }
 
-  // Select method order
-  if (udata->order > 1)
-  {
-    // Use an ARKode provided table
-    flag = ARKodeSetOrder(arkode_mem, udata->order);
-    if (check_flag(&flag, "ARKodeSetOrder", 1)) { return 1; }
-  }
-  else
-  {
-    // Use implicit Euler (requires fixed step size)
-    sunrealtype c[1], A[1], b[1];
-    ARKodeButcherTable B = NULL;
-
-    // Create implicit Euler Butcher table
-    c[0] = A[0] = b[0] = ONE;
-    B                  = ARKodeButcherTable_Create(1, 1, 0, c, A, b, NULL);
-    if (check_flag((void*)B, "ARKodeButcherTable_Create", 0)) { return 1; }
-
-    // Attach the Butcher table
-    flag = ARKStepSetTables(arkode_mem, 1, 0, B, NULL);
-    if (check_flag(&flag, "ARKStepSetTables", 1)) { return 1; }
-
-    // Free the Butcher table
-    ARKodeButcherTable_Free(B);
-  }
+  // Use an ARKode provided table
+  flag = ARKodeSetOrder(arkode_mem, udata->order);
+  if (check_flag(&flag, "ARKodeSetOrder", 1)) { return 1; }
 
   // Set fixed step size or adaptivity method
   if (udata->hfixed > ZERO)
@@ -2020,7 +1998,7 @@ static int OpenOutput(UserData* udata)
 static int WriteOutput(sunrealtype t, N_Vector u, UserData* udata)
 {
   int flag;
-  sunrealtype max;
+  sunrealtype max = ZERO;
   bool outproc = (udata->myid_c == 0);
 
   if (udata->output > 0)

examples/arkode/CXX_parhyp/ark_heat2D_hypre_pfmg.cpp

@@ -2534,7 +2534,7 @@ static int OpenOutput(UserData* udata)
 static int WriteOutput(sunrealtype t, N_Vector u, UserData* udata)
 {
   int flag;
-  sunrealtype max;
+  sunrealtype max = ZERO;
   bool outproc = (udata->myid_c == 0);
 
   if (udata->output > 0)

examples/arkode/CXX_serial/ark_advection_diffusion_reaction.hpp

@@ -266,7 +266,7 @@ int SetIC(N_Vector y, UserData& udata);
 // -----------------------------------------------------------------------------
 
 // Check function return flag
-int check_flag(int flag, const string funcname)
+static int check_flag(int flag, const string funcname)
 {
   if (flag < 0)
   {
@@ -277,15 +277,15 @@ int check_flag(int flag, const string funcname)
 }
 
 // Check if a function returned a NULL pointer
-int check_ptr(void* ptr, const string funcname)
+static int check_ptr(void* ptr, const string funcname)
 {
   if (ptr) { return 0; }
   cerr << "ERROR: " << funcname << " returned NULL" << endl;
   return 1;
 }
 
 // Print ERK integrator statistics
-int OutputStatsERK(void* arkode_mem, UserData& udata)
+static int OutputStatsERK(void* arkode_mem, UserData& udata)
 {
   int flag;
 
@@ -309,7 +309,7 @@ int OutputStatsERK(void* arkode_mem, UserData& udata)
 }
 
 // Print ARK integrator statistics
-int OutputStatsARK(void* arkode_mem, UserData& udata)
+static int OutputStatsARK(void* arkode_mem, UserData& udata)
 {
   int flag;
 
@@ -362,8 +362,8 @@ int OutputStatsARK(void* arkode_mem, UserData& udata)
 }
 
 // Print MRI integrator statistics
-int OutputStatsMRIARK(void* arkode_mem, MRIStepInnerStepper fast_mem,
-                      UserData& udata)
+static int OutputStatsMRIARK(void* arkode_mem, MRIStepInnerStepper fast_mem,
+                             UserData& udata)
 {
   int flag;
 
@@ -461,7 +461,7 @@ int OutputStatsMRIARK(void* arkode_mem, MRIStepInnerStepper fast_mem,
 }
 
 // Save current stats
-int UpdateCVodeStats(CVodeInnerStepperContent* content)
+static int UpdateCVodeStats(CVodeInnerStepperContent* content)
 {
   int flag;
   long int nst, netf, nfe, nni, nncf, nsetups, nje;
@@ -498,8 +498,8 @@ int UpdateCVodeStats(CVodeInnerStepperContent* content)
 }
 
 // Print MRI integrator statistics
-int OutputStatsMRICVODE(void* arkode_mem, MRIStepInnerStepper fast_mem,
-                        UserData& udata)
+static int OutputStatsMRICVODE(void* arkode_mem, MRIStepInnerStepper fast_mem,
+                               UserData& udata)
 {
   int flag;
 
@@ -570,7 +570,7 @@ int OutputStatsMRICVODE(void* arkode_mem, MRIStepInnerStepper fast_mem,
 }
 
 // Print command line options
-void InputHelp()
+static void InputHelp()
 {
   cout << endl;
   cout << "Command line options:" << endl;
@@ -662,8 +662,8 @@ inline void find_arg(vector<string>& args, const string key, bool& dest,
   }
 }
 
-int ReadInputs(vector<string>& args, UserData& udata, UserOptions& uopts,
-               SUNContext ctx)
+static int ReadInputs(vector<string>& args, UserData& udata, UserOptions& uopts,
+                      SUNContext ctx)
 {
   if (find(args.begin(), args.end(), "--help") != args.end())
   {
@@ -785,7 +785,7 @@ int ReadInputs(vector<string>& args, UserData& udata, UserOptions& uopts,
 }
 
 // Print user data
-int PrintSetup(UserData& udata, UserOptions& uopts)
+static int PrintSetup(UserData& udata, UserOptions& uopts)
 {
   cout << endl;
   cout << "Problem parameters and options:" << endl;
@@ -1147,7 +1147,7 @@ int PrintSetup(UserData& udata, UserOptions& uopts)
 }
 
 // Initialize output
-int OpenOutput(UserData& udata, UserOptions& uopts)
+static int OpenOutput(UserData& udata, UserOptions& uopts)
 {
   // Header for status output
   if (uopts.output)
@@ -1183,7 +1183,8 @@ int OpenOutput(UserData& udata, UserOptions& uopts)
 }
 
 // Write output
-int WriteOutput(sunrealtype t, N_Vector y, UserData& udata, UserOptions& uopts)
+static int WriteOutput(sunrealtype t, N_Vector y, UserData& udata,
+                       UserOptions& uopts)
 {
   if (uopts.output)
   {
@@ -1212,7 +1213,7 @@ int WriteOutput(sunrealtype t, N_Vector y, UserData& udata, UserOptions& uopts)
 }
 
 // Finalize output
-int CloseOutput(UserOptions& uopts)
+static int CloseOutput(UserOptions& uopts)
 {
   // Footer for status output
   if (uopts.output)

examples/cvode/CXX_parallel/cv_heat2D_p.cpp

@@ -1620,7 +1620,7 @@ static int OpenOutput(UserData* udata)
 static int WriteOutput(sunrealtype t, N_Vector u, UserData* udata)
 {
   int flag;
-  sunrealtype max;
+  sunrealtype max = ZERO;
   bool outproc = (udata->myid_c == 0);
 
   if (udata->output > 0)

examples/cvode/CXX_parhyp/cv_heat2D_hypre_ls.cpp

@@ -1498,7 +1498,7 @@ static int WaitRecv(UserData* udata)
 // -----------------------------------------------------------------------------
 
 // Initialize memory allocated within Userdata
-UserData::UserData(sundials::Context& sunctx) : sunctx(sunctx)
+UserData::UserData(sundials::Context& ctx) : sunctx(ctx)
 {
   // Diffusion coefficient
   kx = ONE;
@@ -1932,7 +1932,7 @@ static int OpenOutput(UserData* udata)
 static int WriteOutput(sunrealtype t, N_Vector u, UserData* udata)
 {
   int flag;
-  sunrealtype max;
+  sunrealtype max = ZERO;
   bool outproc = (udata->myid_c == 0);
 
   if (udata->output > 0)

examples/cvode/CXX_parhyp/cv_heat2D_hypre_pfmg.cpp

@@ -1970,7 +1970,7 @@ static int WaitRecv(UserData* udata)
 // -----------------------------------------------------------------------------
 
 // Initialize memory allocated within Userdata
-UserData::UserData(sundials::Context& sunctx) : sunctx(sunctx)
+UserData::UserData(sundials::Context& ctx) : sunctx(ctx)
 {
   // Diffusion coefficient
   kx = ONE;
@@ -2446,7 +2446,7 @@ static int OpenOutput(UserData* udata)
 static int WriteOutput(sunrealtype t, N_Vector u, UserData* udata)
 {
   int flag;
-  sunrealtype max;
+  sunrealtype max = ZERO;
   bool outproc = (udata->myid_c == 0);
 
   if (udata->output > 0)

examples/cvode/CXX_serial/cv_heat2D.hpp

@@ -107,7 +107,7 @@ UserData::~UserData()
 // -----------------------------------------------------------------------------
 
 // Compute the exact solution
-int Solution(sunrealtype t, N_Vector u, UserData& udata)
+static int Solution(sunrealtype t, N_Vector u, UserData& udata)
 {
   auto uarray = N_VGetArrayPointer(u);
   if (check_ptr(uarray, "N_VGetArrayPointer")) { return -1; }
@@ -137,7 +137,7 @@ int Solution(sunrealtype t, N_Vector u, UserData& udata)
 }
 
 // Compute the solution error
-int SolutionError(sunrealtype t, N_Vector u, N_Vector e, UserData& udata)
+static int SolutionError(sunrealtype t, N_Vector u, N_Vector e, UserData& udata)
 {
   // Compute true solution
   auto flag = Solution(t, e, udata);
@@ -151,7 +151,7 @@ int SolutionError(sunrealtype t, N_Vector u, N_Vector e, UserData& udata)
 }
 
 // Print command line options
-void InputHelp()
+static void InputHelp()
 {
   std::cout << std::endl
             << "Command line options:\n"
@@ -176,7 +176,7 @@ void InputHelp()
 }
 
 // Read command line inputs
-int ReadInputs(std::vector<std::string>& args, UserData& udata)
+static int ReadInputs(std::vector<std::string>& args, UserData& udata)
 {
   if (find(args.begin(), args.end(), "--help") != args.end())
   {
@@ -212,7 +212,7 @@ int ReadInputs(std::vector<std::string>& args, UserData& udata)
 }
 
 // Print user data
-void PrintUserData(UserData& udata)
+static void PrintUserData(UserData& udata)
 {
   std::cout << std::endl
             << "2D Heat problem:\n"
@@ -243,7 +243,7 @@ void PrintUserData(UserData& udata)
 }
 
 // Initialize output
-int OpenOutput(UserData& udata)
+static int OpenOutput(UserData& udata)
 {
   // Header for status output
   std::cout << std::scientific
@@ -280,7 +280,7 @@ int OpenOutput(UserData& udata)
 }
 
 // Write output
-int WriteOutput(sunrealtype t, N_Vector u, N_Vector e, UserData& udata)
+static int WriteOutput(sunrealtype t, N_Vector u, N_Vector e, UserData& udata)
 {
   // Compute the error
   auto flag = SolutionError(t, u, e, udata);
@@ -325,7 +325,7 @@ int WriteOutput(sunrealtype t, N_Vector u, N_Vector e, UserData& udata)
 }
 
 // Finalize output
-int CloseOutput(UserData& udata)
+static int CloseOutput(UserData& udata)
 {
   // Footer for status output
   std::cout << " ----------------------------------------------"

examples/cvode/CXX_serial/cv_kpr.hpp

@@ -86,7 +86,7 @@ inline int true_sol(sunrealtype t, sunrealtype* u, sunrealtype* v)
 // -----------------------------------------------------------------------------
 
 // Print command line options
-void InputHelp()
+static void InputHelp()
 {
   std::cout << std::endl;
   std::cout << "Command line options:" << std::endl;
@@ -98,7 +98,8 @@ void InputHelp()
   std::cout << "  --nout         : number of outputs\n";
 }
 
-int ReadInputs(std::vector<std::string>& args, Options& opts, SUNContext ctx)
+static int ReadInputs(std::vector<std::string>& args, Options& opts,
+                      SUNContext ctx)
 {
   if (find(args.begin(), args.end(), "--help") != args.end())
   {