Disambiguate shared and static libs .lib files on Windows using MSVC
#455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriendelsalle
requested review from
balos1,
gardner48,
cswoodward and
drreynolds
as code owners
5 tasks
mmuetzel
reviewed
Apr 19, 2024
|
Please add a note about this change to |
… shared on windows
Co-authored-by: Markus Mützel <[email protected]>
adriendelsalle
force-pushed
the
fix-static-and-shared-on-win
branch
from
af04a7c
to
515e89b
Compare
|
balos1
approved these changes
May 16, 2024
gardner48
pushed a commit
that referenced
this pull request
Jun 20, 2024
#455) Description --- Disambiguate shared and static libs `.lib` files on Windows using MSVC Suffix library output name with `_static` when building both static and shared libs on Windows Closes #454 --------- Co-authored-by: Markus Mützel <[email protected]> Co-authored-by: Cody Balos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disambiguate shared and static libs
.libfiles on Windows using MSVCSuffix library output name with
_staticwhen building both static and shared libs on WindowsCloses #454