Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Benchpark use of current Ramble #163

Closed

Conversation

scheibelp
Copy link
Collaborator

@scheibelp scheibelp commented Mar 8, 2024

Current Benchpark breaks w/ Ramble >= GoogleCloudPlatform/ramble@bab6ff3 (PR https://github.com/GoogleCloudPlatform/ramble/pull/428)

ramble -P -D <dir> workspace setup
==> Error: Command workspace does not exist.

(EDIT March 18: the second error described here has since been fixed in Ramble) installing Ramble's requirements.txt leads to another error:

ramble -P -D <dir> workspace setup
...
Environment saxpy references undefined package {modifier_package_name}

This is attempting to resolve these problems (but for now just addresses the first in CI).

@github-actions github-actions bot added the ci Involving Project CI & Unit Tests label Mar 8, 2024
@github-actions github-actions bot added the experiment New or modified experiment label Mar 8, 2024
@scheibelp scheibelp changed the title Fix Benchpark use of current ramble Fix Benchpark use of current Ramble Mar 8, 2024
@scheibelp scheibelp mentioned this pull request Mar 8, 2024
@scheibelp scheibelp marked this pull request as draft March 8, 2024 23:58
@pearce8
Copy link
Collaborator

pearce8 commented Mar 16, 2024

@scheibelp is this ready to be merged?

@scheibelp
Copy link
Collaborator Author

is this ready to be merged?

Not yet: Ramble has fixed the second problem. I wanted to consider whether we need to automatically install requirements.txt to handle the first

@pearce8 pearce8 added this to the v0.1.1 milestone Mar 26, 2024
@scheibelp
Copy link
Collaborator Author

#196 does this more-robustly and has been merged.

@scheibelp scheibelp closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Involving Project CI & Unit Tests experiment New or modified experiment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants