Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlinx serialization support #179

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

makeevrserg
Copy link

@makeevrserg makeevrserg commented Apr 18, 2024

This PR contains serializers along with tests for them:

  • ImmutableListSerializer
  • PersistentListSerializer
  • ImmutableSetSerializer
  • PersistentSetSerializer
  • PersistentHashSetSerializer
  • ImmutableMapSerializer
  • PersistentMapSerializer
  • PersistentHashMapSerializer

This PR is relevant to #63

@LionZXY
Copy link

LionZXY commented Apr 19, 2024

I support the changes, but I also understand how unpleasant it will be to add a new library to the standard distribution.
The main problem is Serialization and ImmutableList are from the same "Kotlin world" and people expect better support between them

From the user's point of view, the solution proposed by @makeevrserg is the best - the presence of an officially supported solution from the kotlin team.

But I understand that this will be difficult for the Kotlin team - maybe then make a separate library for this and link to it?

Related with #63 , #138, #17

@qurbonzoda qurbonzoda self-requested a review April 22, 2024 20:13
@xiaozhikang0916
Copy link

Is this pr still in progress? Noticed that it has been 7 months without update.

And, is it possible to provide a well configured Serializers module so users can avoid adding @Serializable(with = ImmutableXXXSerializer::class) to all immutable collection properties?

@makeevrserg
Copy link
Author

makeevrserg commented Nov 19, 2024

Is this pr still in progress? Noticed that it has been 7 months without update.

And, is it possible to provide a well configured Serializers module so users can avoid adding @Serializable(with = ImmutableXXXSerializer::class) to all immutable collection properties?

Is this pr still in progress? Noticed that it has been 7 months without update.

And, is it possible to provide a well configured Serializers module so users can avoid adding @Serializable(with = ImmutableXXXSerializer::class) to all immutable collection properties?

@xiaozhikang0916 The PR is not in draft - it's finished. I didn't updated it because there's no answer from team.

I personally don't like Serializers module because it's not explicit. But as I know, you can add explicit serializer into your json StringFormat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants