Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEI-5001: Switch to TS enums, remove Flow infra #852

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Conversation

kevinbarabash
Copy link
Contributor

@kevinbarabash kevinbarabash commented Jul 31, 2023

Summary:

Now that none of the downstream consumers of wonder-stuff are using Flow we can get rid of Flow related things from this repo.

Issue: FEI-5001

Test plan:

  • yarn build:types
  • yarn tsc
  • yarn build:docs, open docs/index.html, see that Runtime is now a proper enum
Screen Shot 2023-07-31 at 5 28 22 PM

@kevinbarabash kevinbarabash self-assigned this Jul 31, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jul 31, 2023

🦋 Changeset detected

Latest commit: 3db2a18

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@khanacademy/wonder-stuff-server Major
ws-dev-build-settings Minor
@khanacademy/wonder-stuff-ci Patch
@khanacademy/wonder-stuff-render-environment-jsdom Patch
@khanacademy/wonder-stuff-render-server Patch
@khanacademy/wonder-stuff-sentry Patch
@khanacademy/wonder-stuff-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@khan-actions-bot khan-actions-bot requested a review from a team July 31, 2023 21:21
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Jul 31, 2023

Gerald

Required Reviewers
  • @Khan/frontend-infra for changes to package.json, .changeset/silver-experts-attend.md, .changeset/young-cameras-fail.md, packages/tsconfig-shared.json, .github/workflows/node-ci.yml, packages/wonder-stuff-server/src/types.ts, packages/wonder-stuff-render-server/src/__tests__/run-server.test.ts, packages/wonder-stuff-render-server/src/__tests__/start-trace-agent-impl.test.ts, packages/wonder-stuff-server/src/middleware/wrap-with-middleware.ts, packages/wonder-stuff-server/src/middleware/__tests__/request-authentication.test.ts

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #852 (3db2a18) into main (9950616) will not change coverage.
Report is 32 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #852   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           96        96           
  Lines         1371      1368    -3     
  Branches       352       337   -15     
=========================================
- Hits          1371      1368    -3     
Files Changed Coverage Δ
...tuff-server/src/middleware/wrap-with-middleware.ts 100.00% <ø> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa7daca...3db2a18. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2023

Size Change: 0 B

Total Size: 4.51 kB

ℹ️ View Unchanged
Filename Size
packages/wonder-stuff-core/dist/browser/es/index.js 1.87 kB
packages/wonder-stuff-sentry/dist/browser/es/index.js 1.66 kB
packages/wonder-stuff-testing/dist/browser/es/index.js 972 B

compressed-size-action

@kevinbarabash kevinbarabash merged commit 4419e81 into main Jul 31, 2023
12 checks passed
@kevinbarabash kevinbarabash deleted the fei-5001 branch July 31, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants