Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigating: #538
Change how we serialize information back info umbraco for block lists.
note: The current way "works" but deploy doesn't like it (do we cares what deploy likes 😉 )
current we serialize the Json in and out as Json all the way down a blocklist. This makes it look nice, and it's easier to track changes, and source code commits, and Umbraco works with this being stuck back into the db.
but technically, block list child values are escaped Json in the DB. this is probibly more efficient 😛 - but it makes for hard to decipher text.
This update now puts the values into the DB in their ugly form.
but it forces the uSync file format to be nice Json, so we keep our nice diff/source control.
The main thing here is separating Blocklist a bit more from the way Nested Content does things, I was going to completely separate it, but in reality, two new abstract methods
GetImportProperty
andGetExportProperty
are enough as they give us the granular control over what we do with a value once it's been mapped.