Increase High Alt Flight experiment reward to account for body modifier #2452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now, the high-altitude flight experiment awards 9.6 science points. This number seems dubious, since 1) the other three cockpit experiments award integer numbers of science points and 2) the Ma1.5 experiment awards 9 points while being much easier than the high-altitude flight experiment. I suspect this is an oversight, as Earth Flying Low has a body modifier of x1, but Earth Flying High has x0.6. If a person wants to award 16 points for high-altitude flight and naively enters the number in the config, only 9.6 points are awarded. There are at least two instances of a dev forgetting the body modifier: 3e1d919 (6+10+12+15 = 43, whereas hypersonic flight requires 1+4+4+12 = 21) and 2ad5d1b (if the dev remembered, he should change the experiment value as well).
Here, I set the base value in the config to 25, so that 15 points are awarded. This is one less than the dev "intended," but 25 and 15 are both integers.