Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note the format for putting in dates for simulations #2363

Merged
merged 8 commits into from
May 11, 2024
Merged

Note the format for putting in dates for simulations #2363

merged 8 commits into from
May 11, 2024

Conversation

Clayell
Copy link
Contributor

@Clayell Clayell commented May 11, 2024

PLEASE CHECK THAT THIS IS ACTUALLY THE RIGHT FORMAT

The format for dates varies around the world, so it is important to actually mention the format that this date is supposed to be in instead of just assuming.

@siimav
Copy link
Contributor

siimav commented May 11, 2024

I'm not entirely sure this is necessary. Why not just change the date example to values that isn't ambiguous?

@Clayell
Copy link
Contributor Author

Clayell commented May 11, 2024

I'm not entirely sure this is necessary. Why not just change the date example to values that isn't ambiguous?

Oh sure, that could also work.
Is it yyyy-mm-dd btw?

@siimav
Copy link
Contributor

siimav commented May 11, 2024

Is it yyyy-mm-dd btw?

Of course! Why would anyone order date components in anything other than ascending or descending?

@Clayell
Copy link
Contributor Author

Clayell commented May 11, 2024

Of course, why would anyone do that? 👀

@siimav siimav merged commit 52dc2a9 into KSP-RO:master May 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants