Revise TargetedSats and CommNetwork balancing #2160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
siimav
changed the title
|
I'm confused, I thought you were changing it so the comm network program required completing Target Sat's First Commsat contract. If you make just the contracts require that, then you can lock yourself by taking comm network without taking Targeted Sats, and not be able to have any contracts. Similarly, GEO Comm Network should require First GEO. |
|
Turns out that the First CommSat contract was already available in both programs. It was just weird that the commnet contracts didn't require it to be completed so I fixed that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give both programs the same per-year payout so there doesn't exist a perverse incentive to pick commnet over targeted sats.
Also, at least with the contracts we have right now in those programs I really can't justify commnet paying more than targetedSats.