Prevent spamming spyware when facility upgrade fails to apply

KSP-RO · Aug 12, 2024 · ec9d66b · ec9d66b
1 parent a8764ce
commit ec9d66b
Showing 1 changed file with 12 additions and 9 deletions.
diff --git a/Source/RP0/SpaceCenter/Projects/FacilityUpgradeProject.cs b/Source/RP0/SpaceCenter/Projects/FacilityUpgradeProject.cs
@@ -54,7 +54,7 @@ public void Abort()
             }
         }
 
-        public void Apply()
+        public bool Apply()
         {
             RP0Debug.Log($"Upgrading {name} to level {upgradeLevel}");
             KCTUtilities.SetFacilityLevel(FacilityType, upgradeLevel);
@@ -70,6 +70,8 @@ public void Apply()
             {
                 RP0Debug.LogError($"Setting facility level failed, Current: {newLvl} Desired: {upgradeLevel}");
             }
+
+            return upgradeProcessed;
         }
 
         public static List<UpgradeableFacility> GetFacilityReferencesById(string id)
@@ -136,15 +138,16 @@ protected override void ProcessComplete()
         {
             if (ScenarioUpgradeableFacilities.Instance != null && !SpaceCenterManagement.Instance.ErroredDuringOnLoad)
             {
-                Apply();
-
-                try
-                {
-                    SCMEvents.OnFacilityUpgradeComplete?.Fire(this);
-                }
-                catch (Exception ex)
+                if (Apply())
                 {
-                    Debug.LogException(ex);
+                    try
+                    {
+                        SCMEvents.OnFacilityUpgradeComplete?.Fire(this);
+                    }
+                    catch (Exception ex)
+                    {
+                        Debug.LogException(ex);
+                    }
                 }
             }
         }