fix warnings caused by connect(nullptr, ...)

KDAB · Sep 26, 2022 · 299ae5c · 299ae5c
1 parent 70232a3
commit 299ae5c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/src/resultsbottomuppage.cpp b/src/resultsbottomuppage.cpp
@@ -68,7 +68,8 @@ ResultsBottomUpPage::ResultsBottomUpPage(FilterAndZoomStack* filterStack, PerfPa
     ResultsUtil::setupCostDelegate(m_model, ui->bottomUpTreeView);
     ResultsUtil::setupContextMenu(ui->bottomUpTreeView, contextMenu, m_model, filterStack, this);
 
-    connect(parser, &PerfParser::bottomUpDataAvailable, this, &ResultsBottomUpPage::setBottomUpResults);
+    if (parser)
+        connect(parser, &PerfParser::bottomUpDataAvailable, this, &ResultsBottomUpPage::setBottomUpResults);
 
     ResultsUtil::setupResultsAggregation(ui->costAggregationComboBox);
 }

diff --git a/src/resultspagediff.cpp b/src/resultspagediff.cpp
@@ -47,7 +47,7 @@ ResultsPageDiff::ResultsPageDiff(QWidget* parent)
     , m_exportMenu(new QMenu(tr("Export"), this))
     , m_resultsBottomUpPage(
           new ResultsBottomUpPage(m_filterAndZoomStack, nullptr, m_costContextMenu, m_exportMenu, this))
-    , m_resultsTopDownPage(new ResultsTopDownPage(m_filterAndZoomStack, m_fileA, m_costContextMenu, this))
+    , m_resultsTopDownPage(new ResultsTopDownPage(m_filterAndZoomStack, nullptr, m_costContextMenu, this))
     , m_resultsFlameGraphPage(new ResultsFlameGraphPage(m_filterAndZoomStack, m_fileA, m_exportMenu, this))
     , m_resultsCallerCalleePage(new ResultsCallerCalleePage(m_filterAndZoomStack, m_fileA, m_costContextMenu, this))
     , m_timeLineWidget(new TimeLineWidget(m_fileA, m_filterMenu, m_filterAndZoomStack, this))

diff --git a/src/resultstopdownpage.cpp b/src/resultstopdownpage.cpp
@@ -28,7 +28,8 @@ ResultsTopDownPage::ResultsTopDownPage(FilterAndZoomStack* filterStack, PerfPars
     ResultsUtil::setupCostDelegate(m_model, ui->topDownTreeView);
     ResultsUtil::setupContextMenu(ui->topDownTreeView, contextMenu, m_model, filterStack, this);
 
-    connect(parser, &PerfParser::topDownDataAvailable, this, &ResultsTopDownPage::setTopDownResults);
+    if (parser)
+        connect(parser, &PerfParser::topDownDataAvailable, this, &ResultsTopDownPage::setTopDownResults);
 
     ResultsUtil::setupResultsAggregation(ui->costAggregationComboBox);
 }