Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues preventing library from building with Qt 6 #9

Merged
merged 5 commits into from
Jun 11, 2024

Conversation

Cuperino
Copy link
Member

@Cuperino Cuperino commented Jun 8, 2024

Changes:

  1. CMake instructions now handle both Qt 6 and Qt 5
  2. Pass correct QString-like type to setWindowTitle to fix build error
  3. Remove qAsConst optimization to address deprecation warning
  4. Increase CMake minimum version to address old CMake versions deprecation warning
  5. Perform the install step after the Framework target property is set and add Framework indicator to the install call to address warning regarding possible incorrect path warning
  6. Add CMakeLists.txt.user and build directories to .gitignore
  7. Update GitHub workflow by adding Qt 6 and bumping macOS version

1. Perform the install step after the Framework target property is set
2. Add Framework indicator to the install call
@Cuperino Cuperino force-pushed the fix-qt6-build-issues branch 8 times, most recently from 74a627e to 6ca3b14 Compare June 9, 2024 20:53
.github/workflows/build.yml Outdated Show resolved Hide resolved
@Cuperino Cuperino force-pushed the fix-qt6-build-issues branch 2 times, most recently from 4b5c9f8 to 7eacec0 Compare June 9, 2024 21:06
@dantti
Copy link
Member

dantti commented Jun 9, 2024

Also while you are at it, use macos-latest (& friends), the create build dir can be removed, and for Qt5.15 macos you can fix it by forcing only x86_64 builds, I fixed a few other kdab repos due new macos-latest being AppleSilicon now

@Cuperino Cuperino force-pushed the fix-qt6-build-issues branch 3 times, most recently from 83d8fbb to a133511 Compare June 9, 2024 21:39
@dantti
Copy link
Member

dantti commented Jun 9, 2024

see https://github.com/KDAB/GammaRay/blob/master/.github/workflows/build.yml you need to pass it to cmake

@Cuperino Cuperino force-pushed the fix-qt6-build-issues branch 2 times, most recently from 67c2da7 to e500ef1 Compare June 9, 2024 22:14
@Cuperino Cuperino requested a review from dantti June 9, 2024 22:18
.github/workflows/build.yml Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@Cuperino Cuperino force-pushed the fix-qt6-build-issues branch 2 times, most recently from 73b2bfa to 7829b75 Compare June 10, 2024 01:13
@Cuperino Cuperino self-assigned this Jun 10, 2024
This addresses CMake versions < 3 deprecation warning
1. CMake instructions now handle both Qt 6 and Qt 5
2. Pass correct QString-like type to setWindowTitle
3. Remove qAsConst optimization to address deprecation warning
Copy link
Member

@dantti dantti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cschleifenbaum cschleifenbaum merged commit 7ce56ae into master Jun 11, 2024
8 checks passed
@Cuperino Cuperino deleted the fix-qt6-build-issues branch June 11, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants