-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues preventing library from building with Qt 6 #9
Conversation
1. Perform the install step after the Framework target property is set 2. Add Framework indicator to the install call
74a627e
to
6ca3b14
Compare
4b5c9f8
to
7eacec0
Compare
Also while you are at it, use macos-latest (& friends), the create build dir can be removed, and for Qt5.15 macos you can fix it by forcing only x86_64 builds, I fixed a few other kdab repos due new macos-latest being AppleSilicon now |
83d8fbb
to
a133511
Compare
see https://github.com/KDAB/GammaRay/blob/master/.github/workflows/build.yml you need to pass it to cmake |
67c2da7
to
e500ef1
Compare
73b2bfa
to
7829b75
Compare
This addresses CMake versions < 3 deprecation warning
1. CMake instructions now handle both Qt 6 and Qt 5 2. Pass correct QString-like type to setWindowTitle 3. Remove qAsConst optimization to address deprecation warning
254c166
to
70e2a2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes: