Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated VAL files in ROSPlan repo #202

Open
oscar-lima opened this issue Jun 16, 2019 · 2 comments
Open

Repeated VAL files in ROSPlan repo #202

oscar-lima opened this issue Jun 16, 2019 · 2 comments
Labels

Comments

@oscar-lima
Copy link
Collaborator

e.g. rosplan_dependencies/VAL/include/DebugWriteController.h

vs

rosplan_knowledge_base/src/VALfiles/DebugWriteController.h

@m312z
Copy link
Contributor

m312z commented Jul 5, 2019

What's the question? We love VAL so we have it twice.

In fact, the version in ROSPlan dependencies is a submodule pointing to the VAL repository (KCL-Planning/VAL) while the version in rosplan_knowledge_base is a much older version that has had the source copied in.

The open task is to remove the VAL source from rosplan_knowledge_base and use the rosplan_dependencies version instead. There are a few minor differences between the two versions that need to be accounted for.

@oscar-lima
Copy link
Collaborator Author

Ok, thanks for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants