-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI and i18n Updates #2436
Open
itsTheFae
wants to merge
20
commits into
Just-Some-Bots:dev
Choose a base branch
from
itsTheFae:ui-and-i18n
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
UI and i18n Updates #2436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds setalias command. Adds several dev-only commands for project maintenance. Adds option for Opus audio. Adds option to remove embed footer. Adds sub-command syntax for permissions. Adds optional new permissions management. Enables MusicBot to generate example config & perms files. Removes cruft .travis.yml file. Rename oauth2 username to avoid conflict with yt-dlp. Replace docstring help with `command_helper` decorator. Replace JSON i18n with gettext, with support for logs and discord. Extend python logger class rather than virtually construct it. (this might fix 3.13) Touch nearly every printed string in MusicBot. :)
…ist. Proper fix for generating missing options and permissions files. Enable moving all writable directories with --write-dir cli flag. Convert some more constants for the above cli option.
These provide similar information about translations that Crowdin does.
lint/format lang.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev
branch (the latest developmental version), and this pull request is targeting that branch as a baseDescription
The massive UI / i18n PR is here. As usual, there was some scope creep but thanks to the test rig much of it has been tested and seems to be working as expected now.
The short list of changes is thus:
--write-dir
CLI flag..travis.yml
file.@command_helper
decorator.Response
objects fromdiscord.Embed
to make UseEmbeds option consistent.Please see the ./i18n/readme.md file for more info on how translations work and how to use them.
While this PR removes all the existing
./config/i18n/
files, I have attempted to replace some of the existing translations using Machine Translation from Crowdin primarily.I'm sure the translations could use some work. I left the
crowdin.yml
file in this PR as a template for setting up crowdin on the main repository (or forks), following this PR. I think it is a pretty good way to keep track of translations personally and would suggest it be set up on the main repo if maintainers are willing to allow/use it.I've also included some bundled scripts to hopefully make maintaining translations easier even without the use of an online service.
I hope these changes strike you as sensible and acceptable.
Guides / Documentation
This version of MusicBot is capable of generating portions of the documentation from its source code.
These generated changes as well as many updates to various install guides and sections are in a separate PR.
Please review PR #2437 to see the proposed documentation changes.
Help test this PR
Use the following commands to create a local copy of this PR for testing or contribution:
Switching back later is simple,
git switch dev
or your previous target branch. If you made changes you will want to stash or reset before switching branches.