…id exception

…ning parts of save/unsave commands

Target the dev branch.

Update the way we grab a video ID from a url to account for links being used that don't have the watchv in it. Could potentially solve #2341?

Fix typo.

There was no point in having a save command since the autoplaylist command has it.

Adds 'autoplaylist' command to allow better autoplaylist manipulation

Target was merged.

Saw this requested a few different times. I tested with 1 server, hasn't been tested with multiple servers. Should be fine but time will tell.

…he bot with them.

Make sure we don't disconnect from binded voice channels. Add a little more detail about canceled timers.

Never get's used. Every byte matters.

Thanks ole for pointing out the way to do this.

I'm not really sure if this is wanted or needed but I like it. If anyone complains it can always be removed.

Refactor to use ssd instead of a separate list for guild ID's and timers.

example_options.ini: added space between text and #

Missed one lol

…t-timer

updated inactivity timeout logic

* apparently auto_paused was needed, whoops

* Made the text more informative and fixed a bug where the bot would not disconnect when moved between VC's

* ran black

en.json: fixed spelling mistakes

Move message fix

…ing it

…-song

fixed that the autoplaylist skips the current song playing when enabling it

git is needed to install the
git+https://github.com/Rapptz/discord.py pip dependency

Also add missing expire_in

Something weird was going on where this was raising errors, even with no modifications to the code.

commit 607783b
Author: DestinyofYeet <[email protected]>
Date:   Wed Nov 22 14:43:34 2023 +0100

    "Now playing" now respects DeleteNowPlaying option

* Added a round-robin queue

* ran black

* added round_robin_queue to !option

* ran black

* changed default option to no

* Extra info

---------

Co-authored-by: Snow <[email protected]>

A shorthand command of doing the play command and then the shuffle command

I did this wrong, this will correctly shuffle the playlist after it's been fully downloaded. Due to the nature of how _cmd_play works, the first few songs of the playlist will be played in the order they are in the playlist.

There's an issue where using mentions in a title doesn't convert and shows as <@numbers> instead. This ensures now playing mentions work correctly by putting it into a field instead of a title. I'm sure there's a better way to hack the name parameter for add_field but this seems work fine.

Clarify that the playlist plays the first few songs in order only if nothing else is playing first.
Also ran black.

Fix that shuffleplay wasn't actually shuffling due to an early return. Follow same format as the rest of the help docs. Fix format issue for repeat command no songs errror. Add an expire in to repeat command no voice.

* Lets try cache management.

* early bail if no limits are set.  Fix missing pathlib.

* Fix invalid use of rmtree.

* Fix bytes/days in show config

* bytes typo

* Log removed count and size to debug.

* Add 'cache' command for info and on-demand clear.

* Typo

* format_bytes to 3 decimal places.  Add 'days' in time limit info.

* Format uses binary prefix, lets be clear.

* Get file size early.

* Fix formatting in example_options.ini

* improve cache info.

* Add basic automatic cache clear.

* Update cached_audio_bytes when cleared

* Make sure we update the cache size value.

* might as well update here too.

* Add i18n strings for cache command.

* Throw command error on invalid option.

* make sure example_options match config defaults.

* Compat with Windows, only remove cache dir on startup, & fix sorting order.

* Make SaveVideos=no work as expected on Windows.
Also fix a typo.

* StorageLimitBytes now with notation conversion.

* Clarify/Document cache options in example_options.ini

* Function name consistency.

* Linux instead of *nix

* patch spotify.py SSL with certifi

* remove ssl_context from global scope

* Add option and logic to retain autoplaylist data in cache. Testing required.

* await preload in a proper place.

* Add config option to set audio cache directory.
Refactor audio cache into its own class.
Clean up some auto playlist handling.
All to enable cache retention of auto playlist entries...
Some of this could help with stability in the long run though.

* Flake8 & black and fix my errors.

* Handle cache earlier.  Actually save cachemap on updates...
Add some maybe temporary logs for debug.

* Playlist urls now removed from cache map on purge_from_ap.
Fixed broken asyncio.Lock usage.
Refactored with Flake8 and Black.
Added annotations/typing

* Use proper forward ref.

* make autoplaylist command work without player in voice.
Clarify example options more.

* Count retained size against cache immediately.

* satisfy flake8 and black

* don't add the current size in the purge test.

* Initial per-server command prefix

* Add example_option, and file check.

* clean up and add missing import json

* add method to clear prefix

* ensure black format.

* Remove redundant space check.

* Add i18n strings.

* make command list less error prone in multi-guild.

* Try to make emoji prefix possible.

* black format

* tidy output and add i18n string.

* ensure prefix is listed.

* Fix missing prefix

* fix missing , in  i18n/en.json

* make emoji prefix work without backspace required.

* Rename option to EnablePrefixPerGuild instead.

* Add prefix history for better clean command, and match animated emoji/better emoji checking.

* Fix typo, add regex emoji check to on_message, and convert regex to raw strings for Flake8.

* Note for future reference

* Better support for emoji in unicode rather than markdown. Fixed emoji check for animated emoji in help command.

* Add inactivity option based on player state, in addition to VC activity.

* Naming consistency.

* Fix auto join channels check.

* clean up VC and guild references.  Prevent redundant resets.

* Add shorthand english time format support to time-related config options.
Tiny scope creep for this branch...

* missing import re

* I should remove test prints before commits.

* revert scope creep

* Remove guild name from activity message.

* Black & Flake8

* Make sure these timers don't block further execution.

* Make some logs info level and remove log from finally to make it less chatty.

* Update status message on disconnect.

* Make sure to clear both active timers on disconnect.

* Simplify update_now_playing_status.

* check for paused players over just active players.

* black

* black

* Prevent starting an already active VC timer.

* Clarify and document options.

* black

* Revert to LeaveAfterSong to remain compatible with existing config.

Stage channels where being recognized as text channels. This should fix that.
Closes #2252
Add  autoplaylist cache map to gitignore

Edit for stage channels to deafen if set to.

Need to find a better method of error catching, maybe let admin know we need perms then try again after sleeping for some time?

Make np text less ugly

Add some new options and handle invalid options better. I found myself doing repeat on a lot and cycling through everything so I reworked it.
Remove unnecessary json strings.

)

* Proper fix for SSL issue on windows with missing cert store cert.
This should only use certifi if certs are missing, not by default.

* patch only when broken.

* Fix bot._cleanup() method. 
Remove some code cruft from pre 3.8.
Make sure aiohttp isn't closed prematurely...

* Flake8, black, and general clean up.

* Make sure to clean up what could be broken.

* fix this little thing before it stops the show.

* run black on run.py

* Fix error thrown when non-yt link is used.

* run black

* use guild.id in server_specific_data key

* auto black the whole repo.

Also changes skip command permission checks for looped songs.

* Exit the spotify album/playlist loops when clear is used.

* add guild to command args, fix bad ref

* ditch the sleep method. this should work well enough...

Rework repeat off. Set fallback owner group to have skip looped songs perms.

* Fix issue with _get_guild_cmd_prefix in non-guild channels.

* tally num_skips by counting members who are in skippers set of author.id numbers.

* remove TODO note.

* Auto unpause when play-like commands are used.
Clean up the old auto pause code (cause I've learned since then)

* clean up a bit more, ensure things work.

* Flake8

* actually import typing.

* Quote the custom type

* run black on dev merge.  grumble grumble

* correct the function comment.

Can't get it working right, will look into again at a later time. Maybe we need to do something like get_info?

* Attempt full process restart.  Clean up bot.py global. Clean up some of run.py

* Ensure discord TCPConnector is closed.  Run black.

* Use the correct creationflag name.

* Fix _wait_delete_msg() to check for bot.is_closed()

* Make sure logging is shutdown.

* Add i18n and command responses.

* Run black

* attempt upgrade options for restart command

* Remove unused code

* load self.exit_signal with actual signal, not just type.

* make it easier to get RestartCode qualities from RestartSignal

* Update command output and help text.

* ensure black formatting

* git needs shell=True on linux

* Actually decode bytes to utf8.

* run black on merged dev

* run black on merged dev

* Clean up exception handling, and remove cruft import.

* Clean up exception handling and remove cruft import.

* Squashed commit of the following:

commit 7b4b153
Author: Snow <[email protected]>
Date:   Mon Jan 8 20:43:33 2024 -0600

    Remove shuffle play

    Can't get it working right, will look into again at a later time. Maybe we need to do something like get_info?

---------

Co-authored-by: Snow <[email protected]>

Update the disconnect command so that it doesn't say disconnected when it doesn't have an active player in the guild. Additionally adds i18n support.

Update cmd-restart-invalid-arg i18n to match with what's in the code.

This reverts commit 0a0e171.

Missed ` in i18n
Changes show config on launch:
only show timeout's if enabled.
Add search list.

* Fix broken startup is logs directory is missing.

* Run black

* Add certifi to requirements, since it's missing.

* hot fix for timer events in server specific data.

* fix both events.

* half-broken start of a rewrite.

* more half-broken code, stashing on repo :)

* Substantially less broken, but still broken optimizations...

* in the middle of changing ytdlp settings, so this is half broken still.
we call to extract_info many more times that we maybe should, so its time to rectify that...

* Mostly working, requires lots of cleanup. stashing for now.

* Mostly working, mostly tested, just needs tidy up.

* Flake8 and Black

* Make Entry types use and serialize extracted info.

* add shuffle for entries under shuffleplay command.

* Cleanup with a bit of black, flake8 and mypy.

* commit early and often, and this is why.
Mostly code clean up.  Coverage tests still pending.
Tiny scope creeps:
pldump now names files, and tries the public channel if DM fails.
now playing status got a little brush up i guess...

* patch issue in deserialize player. minor typing fixes.

* Fix some empty channel check and bot check issues.

* Fix print() in cmd_skip to use return Response instead.

* Use is_empty_voice_channel util in channel activity checks.

* Force HEAD requests and ytdlp to use the same UA string.  
Sending "MusicBot" UA to some providers will get blocked or rate limited quickly.

* Get more info on duration failures.

* Allow defer queue serialization for better disk IO when importing playlists. 
Preempt failure of YT links by checking for deleted/private names.
Also changes track numbering for tracks missing titles.

* run black

* Fix mypy complaints against ytdlp options.

* Actually send to channel when DM fails. :)

* Detect youtube:search with 0 results.

* Allow StageChannel type in is_empty_voice_channel

* Forgot to import StageChannel

* Improve download checks.

* general clean up, add some notes for later.  Also some black, flake8, and mypy compliance

* check for missing author ahead of download call, and don't spam about it.

* More typing and code clean up.

* run black

* Remove stream check to enable all media through stream...
some code tidy up with info references.

* Fix cmd_search for new backend.

* remove unused method

* run black and do some more mypy typing clean up.

* Remove shlex from search.  The search engines will handle the quotes.

* Start PR prep, remove changes to ignore and flake file.

* Replace EMOJI_IDLE_ICON with sleeping face emoji, and run Black.

* Revert changes in run.py as out of scope from commit 6016bdb

* Fix broken startup if logs directory is missing.

* Add missing certifi requirement.

* Fix bug with missing duration.

* Better compound link support for youtube and ignored carrier videos.

* black format

* file section is now validated + black

* black format I forgot to include

* updated black and re-formatted

Adds CLI args for logs and update checking.
Includes bug fix for python 3.12 deprecation warning.
Converts doBotInit() to setup_hook()
Removes logging code from bot.py and musicbot/__init__.py
Likely includes some groundwork for later changes in util.py

* Refactor Config and add constants for default file paths.
Refactor server_specific_data into its own class.
Adds bot commands `blockuser` and `blocksong`
Removes command `blacklist` replaced by `blockuser`
Adds a bunch of doc strings and linting/typing changes.

* Make sure Files section get validated as well!

* Update .gitignore

* forgot a comma.