Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First version of FolderDict #1005

Merged
merged 9 commits into from
Feb 17, 2024
Merged

First version of FolderDict #1005

merged 9 commits into from
Feb 17, 2024

Conversation

dehann
Copy link
Member

@dehann dehann commented Feb 16, 2024

@Affie , FYI we could use this for a BlobStore too.

@dehann dehann self-assigned this Feb 16, 2024
@dehann dehann added this to the v0.16.2 milestone Feb 16, 2024
@dehann dehann requested a review from Affie February 16, 2024 20:47
@dehann dehann changed the title wip building FolderDict First version of FolderDict Feb 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2024

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (bfa158a) 25.41% compared to head (7446e0e) 26.40%.

Files Patch % Lines
src/dev/FolderDict.jl 62.31% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1005      +/-   ##
==========================================
+ Coverage   25.41%   26.40%   +0.99%     
==========================================
  Files          53       54       +1     
  Lines        2487     2556      +69     
==========================================
+ Hits          632      675      +43     
- Misses       1855     1881      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dehann dehann marked this pull request as ready for review February 17, 2024 04:59
@dehann dehann modified the milestones: v0.16.2, v0.16.3 Feb 17, 2024
@dehann dehann merged commit 854a350 into master Feb 17, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants