Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail CI on failing Windows 32-bit #546

Merged
merged 1 commit into from
Jan 1, 2024
Merged

Conversation

MilesCranmer
Copy link
Collaborator

@MilesCranmer MilesCranmer commented Dec 30, 2023

cc @mkitti @Moelf

This changes the main test suite to not fail the entire CI (with the red X) if the 32-bit windows test fails. This action runner seems extremely flaky, and is currently broken, and I am worried that the red X loses its significance to us if some tests are implicitly expected to fail. (Not to mention it is a visual cue for a package being maintained or not)

I also skip failures on julia-nightly. They are still visible though if you read the logs.

(I remember there was some discussion of whether 32-bit Windows is actually supported or not..... I forget where that was; maybe a PyCall.jl issue? Or in juliaup?)

Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (12cba08) 85.10% compared to head (9184246) 85.10%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #546   +/-   ##
=======================================
  Coverage   85.10%   85.10%           
=======================================
  Files          39       39           
  Lines        2349     2349           
=======================================
  Hits         1999     1999           
  Misses        350      350           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkitti
Copy link
Member

mkitti commented Dec 30, 2023

32-bit Windows is not very high on my priority list, so I agree it can be optional. I would like to know what is causing the error though.

@MilesCranmer
Copy link
Collaborator Author

Yeah I agree we should try to fix it eventually. (But in the meantime it would be nicer to have it just be an optional check)

@MilesCranmer
Copy link
Collaborator Author

I wonder what the other tests keep randomly failing on. Is there any multiprocessing that you know of in the tests? I have had luck preventing segfaults on github actions by specifying a conservative --heap-size-hint. Just seems like the garbage collection needs to be more aggressive on action runners otherwise it gets killed.

@MilesCranmer MilesCranmer merged commit 71b81b6 into master Jan 1, 2024
24 checks passed
@MilesCranmer MilesCranmer deleted the allow-failure branch January 1, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants