Update setup actions and get working on 3.12 #541
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #541 +/- ##
==========================================
- Coverage 85.22% 85.10% -0.13%
==========================================
Files 39 39
Lines 2342 2349 +7
==========================================
+ Hits 1996 1999 +3
- Misses 346 350 +4 ☔ View full report in Codecov by Sentry. |
|
@mkitti @Moelf any idea what this error is from? I haven't seen it before in the CI. does it require a specific additional library installed? I wonder if it's related to that issue we debugged a while back in PyCall.jl: JuliaPy/PyCall.jl#1040 |
|
is it possible it's related to Github updated Ubuntu base version and we need to install one more library from |
|
We should add Julia 1.9 tests. I would be in favor of dropping everything else except Julia 1.6 since it is LTS. Julia 1.4, Julia 1.7, and Julia 1.8 are no longer supported. |
* Fix importlib deprecated API * Test Python 3.12 * Test Julia 1.9 * Fix semantics of exec_module vs create_module * Ensure we can find spec from JuliaModule * Bump version with python 3.12 compat * Declare compat for 3.11 and 3.12
This comment was marked as outdated.
This comment was marked as outdated.
MilesCranmer
force-pushed
the
fix-ci-settings
branch
from
b3b6059
to
6f0c187
Compare
|
I've updated the CI to only test Julia 1.6, 1.9, and 1 (=1.10 currently). It looks like that libstdc++ issue was some unrelated issue with the action runner, rather than the environment being set up incorrectly. It is now working without any changes on my part. The remaining issue is a randomly-occurring "error 245" which apparently is a segfault. But this doesn't appear to be caused by any of the changes in this PR so I suggest we temporarily ignore it and merge (sometimes such segfaults are due to weird memory management on GitHub actions), so that we can have a working Python 3.12 version. Is that okay with you @mkitti? I am unable to merge as I don't have the access rights (since it marks some tests as "Required" even though they aren't ran anymore). So once you are satisfied would it be possible for you to merge? |
MilesCranmer
changed the title
|
This does look better. Let me re-run that one Ubuntu test. |
|
Awesome, thanks! |
|
How do we release the version? I see there is an action with a workflow_dispatch... Do I just trigger that? |
|
Oh wait I think I figured it out. Let me try... |
Squashed commit of the following: commit 12cba08 Merge: 28af425 ce3ac83 Author: Miles Cranmer <[email protected]> Date: Sat Dec 30 02:23:21 2023 +0000 Merge pull request #544 from JuliaPy/update-to-0.6.2 Bump to 0.6.2 with Python 3.12 fix commit ce3ac83 Author: MilesCranmer <[email protected]> Date: Sat Dec 30 02:03:45 2023 +0000 Bump to 0.6.2 with Python 3.12 fix commit 28af425 Author: Miles Cranmer <[email protected]> Date: Fri Dec 29 16:55:50 2023 +0000 Update setup actions and get working on 3.12 (#541) * Update setup actions * Fix PyJulia on Python 3.12 (#538) * Fix importlib deprecated API * Test Python 3.12 * Test Julia 1.9 * Fix semantics of exec_module vs create_module * Ensure we can find spec from JuliaModule * Bump version with python 3.12 compat * Declare compat for 3.11 and 3.12 * Only test 1.6, 1.9, 1
Squashed commit of the following: commit 18589bb Author: MilesCranmer <[email protected]> Date: Sat Dec 30 02:25:30 2023 +0000 Bump to 0.6.2 Squashed commit of the following: commit 12cba08 Merge: 28af425 ce3ac83 Author: Miles Cranmer <[email protected]> Date: Sat Dec 30 02:23:21 2023 +0000 Merge pull request #544 from JuliaPy/update-to-0.6.2 Bump to 0.6.2 with Python 3.12 fix commit ce3ac83 Author: MilesCranmer <[email protected]> Date: Sat Dec 30 02:03:45 2023 +0000 Bump to 0.6.2 with Python 3.12 fix commit 28af425 Author: Miles Cranmer <[email protected]> Date: Fri Dec 29 16:55:50 2023 +0000 Update setup actions and get working on 3.12 (#541) * Update setup actions * Fix PyJulia on Python 3.12 (#538) * Fix importlib deprecated API * Test Python 3.12 * Test Julia 1.9 * Fix semantics of exec_module vs create_module * Ensure we can find spec from JuliaModule * Bump version with python 3.12 compat * Declare compat for 3.11 and 3.12 * Only test 1.6, 1.9, 1
commit 57d6b6a Author: MilesCranmer <[email protected]> Date: Sat Dec 30 02:45:53 2023 +0000 Ensure setuptools installed in test commit 18589bb Author: MilesCranmer <[email protected]> Date: Sat Dec 30 02:25:30 2023 +0000 Bump to 0.6.2 Squashed commit of the following: commit 12cba08 Merge: 28af425 ce3ac83 Author: Miles Cranmer <[email protected]> Date: Sat Dec 30 02:23:21 2023 +0000 Merge pull request #544 from JuliaPy/update-to-0.6.2 Bump to 0.6.2 with Python 3.12 fix commit ce3ac83 Author: MilesCranmer <[email protected]> Date: Sat Dec 30 02:03:45 2023 +0000 Bump to 0.6.2 with Python 3.12 fix commit 28af425 Author: Miles Cranmer <[email protected]> Date: Fri Dec 29 16:55:50 2023 +0000 Update setup actions and get working on 3.12 (#541) * Update setup actions * Fix PyJulia on Python 3.12 (#538) * Fix importlib deprecated API * Test Python 3.12 * Test Julia 1.9 * Fix semantics of exec_module vs create_module * Ensure we can find spec from JuliaModule * Bump version with python 3.12 compat * Declare compat for 3.11 and 3.12 * Only test 1.6, 1.9, 1
This PR tries to fix the CI setting issues in #538, #539, #540. Those PRs can then set this branch to their base.
It also merges the Python 3.12 fix from #538.