-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support sparse array conversion #918
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #918 +/- ##
==========================================
+ Coverage 67.97% 68.33% +0.35%
==========================================
Files 20 21 +1
Lines 2033 2021 -12
==========================================
- Hits 1382 1381 -1
+ Misses 651 640 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This seems to be compatible with other uses in PyCall.jl. Also, doing accessing internet when invoking `convert` is rather wacky.
.github/workflows/system.yml
Outdated
python-version: ['3.x'] | ||
python-version: ['3.9'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for experimenting if windows failure is due to the missing wheel for 3.10
https://github.com/JuliaPy/PyCall.jl/runs/3987045445?check_suite_focus=true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, so it works with 3.9 https://github.com/JuliaPy/PyCall.jl/runs/3987137563?check_suite_focus=true
We either need to wait for SciPy dev to upload the wheel or implement some workaround here.
This reverts commit fecc4c2.
Thanks for reviving this! I didn't notice the CI not passing |
fix #204