change py_str to py_cmd
#794
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simeonschaub
force-pushed
the
py_str_to_py_cmd
branch
from
399c727
to
5e68849
Compare
simeonschaub
commented
Jul 14, 2020
|
I agree that we should leave the string version without a deprecation for now. |
simeonschaub
force-pushed
the
py_str_to_py_cmd
branch
from
a4c63bd
to
586dd5e
Compare
simeonschaub
force-pushed
the
py_str_to_py_cmd
branch
from
586dd5e
to
923b778
Compare
|
@simeonschaub Sorry to comment it after you made all the changes. But I think there are a couple of conceptual issues: #793 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do we already want to deprecate
@py_str? I left it as-is for now, since a lot of code currently depends on PyCall, so throwing a deprecation warning might get annoying pretty quickly.I also still need to update the README and the docs.closes #793