RFC: Add an API to safely add conda packages #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkf
added a commit
to tkf/IPython.jl
that referenced
this pull request
Nov 8, 2018
tkf
force-pushed
the
conda_add
branch
3 times, most recently
from
baa3bc2
to
899518b
Compare
If a package installed via `Conda.add` is not available for installed Python version, `conda` may downgrade Python: https://discourse.julialang.org/t/help-understanding-pycall-related-travis-failure/15957 This breaks PyCall because it stores the path to libpython etc. This patch provides a workaround to the issue by adding an API that wraps `Conda.add` and re-build PyCall if Python version is changed during installation of conda packages. fix JuliaPy/Conda.jl#127
tkf
commented
Nov 9, 2018
|
|
||
| before = Conda.version("python") | ||
| for pkg in packages | ||
| Conda.add(pkg) |
There was a problem hiding this comment.
TODO: switch to Conda.add(packages) once the Conda.jl version containing JuliaPy/Conda.jl#130 is released.
This was referenced Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a package installed via
Conda.addis not available for installedPython version,
condamay downgrade Python:https://discourse.julialang.org/t/help-understanding-pycall-related-travis-failure/15957
This breaks PyCall because it stores the path to libpython etc. This patch provides a workaround to the issue by adding an API that wraps
Conda.addand re-build PyCall if Python version is changed during installation of conda packages. I suggest to recommend this API overpyimport_conda.Proposed API:
fix JuliaPy/Conda.jl#127
fix JuliaPy/PyPlot.jl#382