Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some timings for comparison.
before
after
This is about the same speed as
JuLie.partitions
orAbstractAlgebra.Generic.partitions
. Also the algorithm is fairly simple and straightforward :)Some other remarks
partitions(Int8(n))
to save some memory for large n (the partitions are generated asVector{Int8}
in this case);partitions(0)
returns[Int[]]
andpartitions(-1)
returns an empty iterator (this is treated in Fix integer partitions #82 but has not been merged);integer_partitions
(which I'd suggest to replace completely withcollect(partitions(n))
).