small fixes in GitTools module #3849
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
reviewed
Mar 22, 2024
| @@ -159,9 +159,6 @@ function fetch(io::IO, repo::LibGit2.GitRepo, remoteurl=nothing; header=nothing, | |||
| LibGit2.Callbacks() | |||
| end | |||
| fancyprint && start_progress(io, bar) | |||
| if credentials === nothing | |||
There was a problem hiding this comment.
Shouldn't this be used instead of being removed?
There was a problem hiding this comment.
I was unsure which direction we want to go with this.
I went with removing it as that seemed more conservative to me, but I am open to using it.
I will add a commit to use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making sure the progress bar for cloning actually states that its cloning, rather than fetching.
Removing unused credentials in fetch function.
#3833