Add support for Julia v0.6 [Initial Build] #4
Conversation
Base.scale and Base.scale! were deprecated in v0.5 and removed in v0.6-pre.alpha. Removing their import permits use on v0.6- May require a look in the future.
The lowercase symbol function has been deprecated in favor of the Symbol constructor (#16154)
New normalize and normalize! convenience functions were introduced for normalizing vectors (#13681) This created ambiguity with QuDirac's normalize and normalize! Fix for that In addition, used Symbol constructor to convert Expr objects to Symbol
…oving from v0.3 to v0.6
The keywords used to define types have changed (#19157, #20418) of JuliaLang/julia.
"abstract changes to abstract type ... end", fix for the same.
The typealias keyword is deprecated, and should be replaced with Vector{T} = Array{T,1} or a const assignment (#20500) of JuliaLang/julia.
Fix for the same
Changed Base.(operator) to Base.operator to fix deprecation warnings. Note, this should be replaced in the future
as one no longer defines methods for .* etcetera due to (#17623) of JuliaLang/julia.
|
Hi @TestSubjector! This is quite the endeavor, I commend you for tackling it. I've not really paid much attention to QuDirac since the days of Julia v0.3, and didn't even realize anybody was still interested in using it. At this point, a large number of drastic changes would be necessary to turn this into a high quality Julia package for v0.6. This is both because of all the new Julia features and conventions that have been added/adopted since v0.3, and because this was my first real Julia package (so it has some noobish design warts). Unfortunately, I don't have the time these days to work on QuDirac, so you'd have to work mostly on your own. Sorry about that! If you're still interested in working on it, though, I can at least do quick code reviews for this and future PRs. Let me know what you think. |
|
Thanks. And yes, I'd definitely like to work on this. My semester ends in about a month and I've a few task to complete in the upcoming vacation. But besides that, I'd hopefully be able to contribute to this in my free time. I guess the first priority would be to get the current code up and running. After that, the modifications and new features to be implemented should be focused on. Also, feel free to give any recommendations on how I should proceed from here on. |
| end | ||
|
|
There was a problem hiding this comment.
This whole warning should probably go away, any version handling should just go into the REQUIRE anyway
|
|
||
| Base.hash(i::InnerProduct) = hash(blabel(i), hash(klabel(i))) | ||
| Base.hash(i::InnerProduct, h::Uint64) = hash(hash(i), h) | ||
| Base.hash(i::InnerProduct, h::UInt64) = hash(hash(i), h) |
There was a problem hiding this comment.
This should be UInt instead of UInt64 (to accommodate 32-bit systems)
| @@ -75,15 +75,15 @@ same_num(iex::InnerExpr, n::Number) = iex == InnerExpr(n) | |||
| same_num(n::Number, iex::InnerExpr) = iex == n | |||
|
|
|||
| Base.hash(iex::InnerExpr) = hash(iex.ex) | |||
| Base.hash(iex::InnerExpr, h::Uint64) = hash(hash(iex), h) | |||
| Base.hash(iex::InnerExpr, h::UInt64) = hash(hash(iex), h) | |||
There was a problem hiding this comment.
Same here - UInt64 --> UInt
| StateLabel(label::NTuple{N}, h::Uint64) = new(label, h) | ||
| hash::UInt64 | ||
| StateLabel{N}(label::NTuple{N}) where N = new(label, hash(label)) | ||
| StateLabel{N}(label::NTuple{N}, h::UInt64) where N = new(label, h) |
There was a problem hiding this comment.
Some more UInt64 --> UInt situations. It seems there are a bunch of these - they should all get fixed, but I'll just stop commenting on them.
| normalize(s::DiracState) = (1/norm(s))*s | ||
| normalize!(s::DiracState) = scale!(1/norm(s), s) | ||
| QuDirac.normalize(s::DiracState) = (1/norm(s))*s | ||
| QuDirac.normalize!(s::DiracState) = scale!(1/norm(s), s) |
There was a problem hiding this comment.
QuDirac. --> Base., since Base defines normalize/normalize! these days.
| end | ||
|
|
||
| OpDefExpr(ods::OpDefStr) = OpDefExpr(symbol(ods.op_name), parse(ods.label_args), symbol(ods.lhs_type), parse(ods.rhs)) | ||
| OpDefExpr(ods::OpDefStr) = OpDefExpr(Symbol(ods.op_name), Symbol(parse(ods.label_args)), Symbol(ods.lhs_type), Symbol(parse(ods.rhs))) |
There was a problem hiding this comment.
Hmm...why force these to be Symbols, when before they could be Symbols or Exprs?
Julia has changed so much since I thought about this package that I'm not even sure what a redesign would entail anymore. Likely, a complete rewrite of the package. Here are things I can think of off the top of my head:
Also, folks have done a lot of work on CASes in Julia by now (e.g. Nemo.jl). At this point, it might be the case that all or part of QuDirac should just be rebuilt as a domain-specific package on top of one of these systems instead. Anyway, I'll give you commit access here since I'm not going to be available to help most of the time. Feel free to merge PRs, open/close issues, etc. |
So, this library hasn't been updated in quite a while.
Meanwhile Julia has moved from v0.3 to v0.6, with several breaking changes and redesigns to the language. With reference to Issue #2 , the package was failing to run on Julia v0.4 itself back then.
Hence this PR is an initial attempt to get the library running on Julia v0.6 (skipping 0.4 and 0.5). Included are fixes to deprecated keywords, functions and more. Almost all of the features of the library run with this PR, except the following -
I've kinda gotten stuck on how to fix the above and would like suggestions and/or commits on how to proceed further.