[SPARKNLP-1059] Adding aggressiveMatching parameter to DocumentSimilarityRanker #14370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilojsl
force-pushed
the
bug/SPARKNLP-1059-DocumentSimilarityRanker-columns-issue
branch
from
3e53d4d
to
d20c4de
Compare
danilojsl
force-pushed
the
bug/SPARKNLP-1059-DocumentSimilarityRanker-columns-issue
branch
from
d20c4de
to
81fcbea
Compare
maziyarpanahi
approved these changes
Aug 28, 2024
maziyarpanahi
changed the base branch from
master
to
release/542-release-candidate
maziyarpanahi
added a commit
that referenced
this pull request
Aug 28, 2024
* Adding demo notebook for Image Classification Annotators (#14360) * Upload SwinForImageClassification.ipynb * Uploading ConvNextForImageClassification * [SPARKNLP-1058] Adding aggressiveMatching parameter (#14365) * [SPARKNLP-1059] Adding aggressiveMatching parameter to DocumentSimilarityRanker (#14370) * [SPARKNLP-1059] Adding aggressiveMatching parameter to DocumentSimilarityRanker * [SPARKNLP-1059] Updates Document Similarity Ranker notebook * Bump to 5.4.2 [run doc] * Update Scala and Python APIs * update conda to 5.4.2 [skip test] --------- Co-authored-by: Abdullah mubeen <[email protected]> Co-authored-by: Danilo Burbano <[email protected]> Co-authored-by: github-actions <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces the
aggregationMethodparameter to theDocumentSimilarityRankerannotator. The new parameter allows users to specify the method used to aggregate multiple sentence embeddings into a single vector representation.Motivation and Context
Allows users to tailor the aggregation method to their specific use case, whether they need a general overview (AVERAGE), focus on the initial context (FIRST), or emphasize the strongest signals (MAX).
This change solves the following issues:
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: