-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(www): launch the new webform #1843
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1843 +/- ##
======================================
Coverage 40% 40%
======================================
Files 39 39
Lines 1806 1806
Branches 337 337
======================================
Hits 738 738
Misses 1068 1068
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. I have a question regarding future maintenance, do we need to delete these feature flags in the future ? Or do we just keep them in the code base forever?
Yeah we should delete them. This will just allow an easy launch and a quick rollback path. Once it's landed we should delete the flag and the old components. |
Jigsaw-Code/outline-server#1510 was pushed to production. This can be merged. |
Merge once Jigsaw-Code/outline-server#1510 has landed.