-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(www): enable providers to send custom error responses via the dynamic key #1830
feat(www): enable providers to send custom error responses via the dynamic key #1830
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1830 +/- ##
======================================
- Coverage 32% 32% -1%
======================================
Files 45 45
Lines 2610 2620 +10
Branches 337 340 +3
======================================
+ Hits 859 860 +1
- Misses 1751 1760 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We need to better understand the trade-offs between the different approaches, which also included a client response and a Client API. There are also open questions regarding what format we should use, and what the UI should look like, but they can be decoupled from the chosen approach. |
src/www/app/outline_server_repository/access_key_serialization.ts
Outdated
Show resolved
Hide resolved
src/www/app/outline_server_repository/access_key_serialization.ts
Outdated
Show resolved
Hide resolved
src/www/views/servers_view/server_list_item/server_card/index.ts
Outdated
Show resolved
Hide resolved
src/www/app/outline_server_repository/access_key_serialization.ts
Outdated
Show resolved
Hide resolved
src/www/app/outline_server_repository/access_key_serialization.ts
Outdated
Show resolved
Hide resolved
src/www/app/outline_server_repository/access_key_serialization.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, and it will be super helpful to providers. Thanks for implementing it!
It's ok to merge, but please test the functionality to make sure it's working end-to-end after all the changes.
We also need to think about communicating the new feature in the next release, and perhaps add that to the wiki. |
This PR enables service providers to return an error object to inform the end user about something wrong with their dynamic key or server connection. Service providers could then volunteer contact information via this error message.