Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cordova/apple): don't strip tun2socks debug symbols #1824

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

daniellacosse
Copy link
Contributor

@daniellacosse daniellacosse commented Jan 25, 2024

https://developer.apple.com/documentation/xcode/building-your-app-to-include-debugging-information#Publish-your-app-with-symbol-information

"When archiving your app for distribution, Xcode gathers all binaries and dSYM files for your app and stores them inside the Xcode archive.

If you distribute your app through the App Store or conduct a beta test using TestFlight, you have the option to include the symbol files when uploading your app to App Store Connect."

We should just make sure that option isn't checked/passed into the actool!

@daniellacosse daniellacosse requested a review from a team as a code owner January 25, 2024 22:29
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (85ce8f8) 32% compared to head (a69cb2d) 32%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1824   +/-   ##
======================================
  Coverage      32%     32%           
======================================
  Files          45      45           
  Lines        2609    2609           
  Branches      337     337           
======================================
  Hits          859     859           
  Misses       1750    1750           
Flag Coverage Δ
apple 15% <ø> (ø)
ios 15% <ø> (ø)
maccatalyst 15% <ø> (ø)
macos 15% <ø> (ø)
unittests 32% <ø> (ø)
www 40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jyyi1 jyyi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will likely increase the binary size. Do you have a sense of the increase? Is there a specific reason to include the symbols?

@daniellacosse
Copy link
Contributor Author

This change will likely increase the binary size. Do you have a sense of the increase? Is there a specific reason to include the symbols?

According to the docs I linked above, I believe the symbols are stripped on archival unless you decide to upload them!

@fortuna
Copy link
Collaborator

fortuna commented Feb 5, 2024

Let's make sure to check the binary size in the next release!

@daniellacosse daniellacosse merged commit e11d99e into master Feb 5, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants