Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compose compiler version for kotlin 1.9.24 #5080

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

@eymar eymar requested a review from igordmn July 8, 2024 14:22
@igordmn igordmn self-requested a review July 8, 2024 14:33
@igordmn
Copy link
Collaborator

igordmn commented Jul 8, 2024

We still have a crash on Kotlin 1.9.23 and Kotlin 2.0.0. How difficult it will be to maintain backward compatibility with these Kotlin's?

Alternatively:

  • For 1.9.23 we need to release a new Compiler (not sure if it worth it).
  • For Kotlin 2.0.0 we can decide that it should be updated to a hotfix version of Kotlin 2.0.10

@eymar
Copy link
Member Author

eymar commented Jul 8, 2024

We still have a crash on Kotlin 1.9.23 and Kotlin 2.0.0. How difficult it will be to maintain backward compatibility with these Kotlin's?

Alternatively:
For 1.9.23 we need to release a new Compiler (not sure if it worth it).
For Kotlin 2.0.0 we can decide that it should be updated to a hotfix version of Kotlin 2.0.10

  • For 1.9.23 it's up to us to publish a compiler plugin with a fix. (Probably we don't need to do that, as everyone can use 1.9.24)
  • For 2.0.0, since it's already published, the only way to make 1.7.0- compatible with 2.0.0 is to remove a newly added function in compose runtime (web). Compose compiler (2.0.0) looks for that function, and if it's present, it starts using it (the problem is that 2.0.0 Compose compiler, the web pieces "don't know" about the new function).

IMO, removing the function for only 1 platform is not a future-proof solution, because this way the platforms behaviour might diverge and it might cause other issues.
Suggesting users to switch to 2.0.10 is the best solution IMO, especially considering the Alpha status of CfW.

P.S. The multiplatform compose compiler tests (WIP) will likely prevent such a situation in the future (if they will be running on the latest compose-runtime).

@igordmn
Copy link
Collaborator

igordmn commented Jul 8, 2024

Suggesting users to switch to 2.0.10 is the best solution IMO, especially considering the Alpha status of CfW.

Agree, I didn't take Alpha status into account.

@eymar eymar merged commit 5e810a0 into master Jul 9, 2024
12 checks passed
@eymar eymar deleted the ok/upd_compiler_mapping branch July 9, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants