-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add -path option for injector (#2) #6
base: main
Are you sure you want to change the base?
Conversation
A pull request should be focused to one issue. I think the chinese comment should be removed or change to english but not in this PR. |
…plified Chinese comments and strings to English.
The code page of common.h before editing was EUC (Simplified Chinese), and in my development environment I could not edit it without causing garbled characters. Therefore, I changed the code page to UTF-8 and translated the comments to English. please confirm. |
Dll_Injector/main.cpp
Outdated
const char* initialPath = ""; | ||
for (int index = 1; index < argc; ++index) | ||
{ | ||
if (strcmp(argv[index], "-path") == 0 && index + 1 < argc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Single dash usually use in the short form of argument option, I think it is better to use two dash like --path
.
Also, this dumper is not for CLI user and thats why I use gui to choose save directory. I am not quite sure this PR is the best way to let user choose the initial save directory. For example, if I am a CLI user, why do I just use the argument like |
…f the directory where image files are saved has been changed from "-path" to "--path".
As you pointed out, I changed the command argument from I would also like to answer why I am particular about specifying command arguments. I also have no intention of using When you run As mentioned above, I wanted to save images in a dedicated directory, and having to reselect the directory every time I started If you can specify the initial directory where the image will be saved using the As another workaround, I considered a method of ``displaying the last selected directory first at next startup,'' but I ultimately gave up on this method due to the following requirements. .
|
I have totally understand the situation but I dont think implementing of saving software settings need a lot of modifications. I think use windows regedit for saving and loading settings just need little changes. PS: You should always deal with one problem in one PR, we should solve the |
This is a proposed fix for issue #2.
By specifying
-path <initial directory path name>
as a command argument forDll_Injector.exe
, you can change the initial value of the directory where images are saved.The
-path
command argument is optional.By the way, the code page of the original
common.h
was not UNICODE, and it contained comments in simplified Chinese.When I edited
common.h
, there was a possibility of garbled characters, so I changed the code page to UTF8 with BOM.note that.